Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[lexical-playground] Fix: in playground show component-menu w… #6558

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Aug 26, 2024

Breaks internally, might need to revise the approach or our internal code...

…hen scroll (#6510)"

This reverts commit fd7a93d.

Description

Describe the changes in this pull request

Closes #

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 6:08pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 6:08pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.89 KB (0%)
@lexical/rich-text - esm 31.07 KB (0%)
@lexical/plain-text - cjs 36.49 KB (0%)
@lexical/plain-text - esm 28.41 KB (0%)
@lexical/react - cjs 39.61 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@zurfyx zurfyx marked this pull request as ready for review August 26, 2024 18:26
@zurfyx zurfyx added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 36b8eab Aug 26, 2024
41 checks passed
@etrepum
Copy link
Collaborator

etrepum commented Aug 26, 2024

Can you put together a repro that shows what goes wrong with this approach? It fixed all of the positioning issues that we could find, this revert is an OSS regression

@ivailop7
Copy link
Collaborator

Maybe a complete rewrite of the floating elements - context menu and typeahead/mentions/hashtags suggestions is worth it, maybe using something like https://floating-ui.com/ that would handle all of the render details correctly. All of those popovers are playground-only, so it should be OK relying on a 3rd party package for the rendering of these two. Just food for thought.

@etrepum
Copy link
Collaborator

etrepum commented Aug 26, 2024

Yeah, Floating UI is what I used in the past for doing this sort of thing and it worked well. I don't have a strong opinion on whether we should have a dependency handle floating UI or have an in-tree implementation without known issues but we should certainly not have an in-tree implementation that we know is incorrect for the cases that we demonstrate.

@potatowagon
Copy link
Contributor

Can you put together a repro that shows what goes wrong with this approach? It fixed all of the positioning issues that we could find, this revert is an OSS regression

reintroducing the changes back in #6566 but with gating so we can investigate internally and fix intern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants