Skip to content

Commit

Permalink
Use new Flipper SDK (#27833)
Browse files Browse the repository at this point in the history
Summary:
The FBJNI compat issue is gone so this is working now. �

Still a bit ugly to set up, but that's on our ToDo. Next: Template.

## Changelog

[Android] [Fixed] - Use modern Flipper SDK version for RNTester
Pull Request resolved: #27833

Test Plan:
```
./gradlew :RNTester:android:app:installHermesDebug
```

![Screenshot 2020-01-22 at 09 30 22](https://user-images.githubusercontent.com/9906/72883088-9c012500-3cfb-11ea-9997-b38831196259.png)

Reviewed By: cpojer

Differential Revision: D19513412

Pulled By: passy

fbshipit-source-id: af118bd364ab316732e2a1e657fa1b682bf7da59
  • Loading branch information
passy authored and facebook-github-bot committed Jan 28, 2020
1 parent 4185a45 commit 8259a9d
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions RNTester/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,16 @@ dependencies {
debugImplementation files(hermesPath + "hermes-debug.aar")
releaseImplementation files(hermesPath + "hermes-release.aar")

debugImplementation("com.facebook.flipper:flipper:0.23.4") {
exclude group:'com.facebook.yoga'
exclude group:'com.facebook.flipper', module: 'fbjni'
exclude group:'com.facebook.litho', module: 'litho-annotations'
debugImplementation("com.facebook.flipper:flipper:0.30.2") {
exclude group:'com.facebook.fbjni'
}

debugImplementation("com.facebook.flipper:flipper-network-plugin:0.30.2") {
exclude group:'com.facebook.flipper'
}

debugImplementation("com.facebook.flipper:flipper-fresco-plugin:0.30.2") {
exclude group:'com.facebook.flipper'
}

if (useIntlJsc) {
Expand Down

0 comments on commit 8259a9d

Please sign in to comment.