[Android][RNTester] Use new Flipper SDK #27833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
p: Facebook
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @passy in 8259a9d. When will my fix make it into a release? | Upcoming Releases |
30 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 29, 2020
Summary: Depends on #27833. Updates the Flipper version to the most recent release. ## Changelog [Android] [Changed] - Upgrade Flipper version in default template Pull Request resolved: #27837 Test Plan: This is a bit annoying, but I can't test this against the 0.62-rc.0 version. I tried patching it by running `react-native init --version 0.62.0-rc.0 testproj`, which would fail because of a missing androidx dep. After adding `implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.0.0'` to the deps, that was fixed but now after updating, `libfbjni.so` is missing because my PR #27729 isn't part of the RN dependency yet. Given that this mirrors the RNTester app, I'm pretty confident that the change here is otherwise correct and will work on top of master with the most recent template changes. Differential Revision: D19619365 Pulled By: passy fbshipit-source-id: 5723bd105ab3ab86b7f00e1a26e29e1e9dc58290
rickhanlonii
pushed a commit
that referenced
this pull request
Feb 5, 2020
Summary: The FBJNI compat issue is gone so this is working now. � Still a bit ugly to set up, but that's on our ToDo. Next: Template. ## Changelog [Android] [Fixed] - Use modern Flipper SDK version for RNTester Pull Request resolved: #27833 Test Plan: ``` ./gradlew :RNTester:android:app:installHermesDebug ```  Reviewed By: cpojer Differential Revision: D19513412 Pulled By: passy fbshipit-source-id: af118bd364ab316732e2a1e657fa1b682bf7da59
rickhanlonii
pushed a commit
that referenced
this pull request
Feb 5, 2020
Summary: Depends on #27833. Updates the Flipper version to the most recent release. ## Changelog [Android] [Changed] - Upgrade Flipper version in default template Pull Request resolved: #27837 Test Plan: This is a bit annoying, but I can't test this against the 0.62-rc.0 version. I tried patching it by running `react-native init --version 0.62.0-rc.0 testproj`, which would fail because of a missing androidx dep. After adding `implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.0.0'` to the deps, that was fixed but now after updating, `libfbjni.so` is missing because my PR #27729 isn't part of the RN dependency yet. Given that this mirrors the RNTester app, I'm pretty confident that the change here is otherwise correct and will work on top of master with the most recent template changes. Differential Revision: D19619365 Pulled By: passy fbshipit-source-id: 5723bd105ab3ab86b7f00e1a26e29e1e9dc58290
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: The FBJNI compat issue is gone so this is working now. � Still a bit ugly to set up, but that's on our ToDo. Next: Template. ## Changelog [Android] [Fixed] - Use modern Flipper SDK version for RNTester Pull Request resolved: facebook#27833 Test Plan: ``` ./gradlew :RNTester:android:app:installHermesDebug ```  Reviewed By: cpojer Differential Revision: D19513412 Pulled By: passy fbshipit-source-id: af118bd364ab316732e2a1e657fa1b682bf7da59
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Depends on facebook#27833. Updates the Flipper version to the most recent release. ## Changelog [Android] [Changed] - Upgrade Flipper version in default template Pull Request resolved: facebook#27837 Test Plan: This is a bit annoying, but I can't test this against the 0.62-rc.0 version. I tried patching it by running `react-native init --version 0.62.0-rc.0 testproj`, which would fail because of a missing androidx dep. After adding `implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.0.0'` to the deps, that was fixed but now after updating, `libfbjni.so` is missing because my PR facebook#27729 isn't part of the RN dependency yet. Given that this mirrors the RNTester app, I'm pretty confident that the change here is otherwise correct and will work on top of master with the most recent template changes. Differential Revision: D19619365 Pulled By: passy fbshipit-source-id: 5723bd105ab3ab86b7f00e1a26e29e1e9dc58290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The FBJNI compat issue is gone so this is working now. 🥳
Still a bit ugly to set up, but that's on our ToDo. Next: Template.
Changelog
[Android] [Fixed] - Use modern Flipper SDK version for RNTester
Test Plan