Skip to content

Commit

Permalink
Fix bug with align start not taking into account parent padding (#41687)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebook/yoga#1484

Pull Request resolved: #41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8
  • Loading branch information
joevilches authored and facebook-github-bot committed Dec 8, 2023
1 parent e826d1c commit ea3dd6b
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ static void alignAbsoluteChild(
case Align::Stretch:
case Align::SpaceEvenly:
child->setLayoutPosition(
parent->getFlexStartBorder(crossAxis, direction) +
parent->getLayout().border(flexStartEdge(crossAxis)) +
parent->getLayout().padding(flexStartEdge(crossAxis)) +
child->getFlexStartMargin(
crossAxis, direction, containingBlockWidth),
flexStartEdge(crossAxis));
Expand Down

0 comments on commit ea3dd6b

Please sign in to comment.