New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with align start not taking into account parent padding #41687

Closed

joevilches wants to merge 4 commits into facebook:main from joevilches:export-D51374086

Contributor

joevilches commented Nov 29, 2023

Summary: Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Nov 29, 2023

This pull request was exported from Phabricator. Differential Revision: D51374086

facebook-github-bot added p: Facebook Partner fb-exported labels

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

1ad436e

…book#41687)

Summary:

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

d9019a2

…book#41687)

Summary:

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

f1372cc

…book#41687)

Summary:

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches mentioned this pull request

Fix bug with align start not taking into account parent padding facebook/yoga#1484

Closed

joevilches added a commit to joevilches/yoga that referenced this pull request


          Fix bug with align start not taking into account parent padding

f394da9

Summary:
X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

fbshipit-source-id: 979deef45c895bf84ff9e0dbb128e7f94643e88b

analysis-bot commented Nov 29, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,515,586	+1,926
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	19,890,268	+6,019
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 8081265
Branch: main

joevilches force-pushed the export-D51374086 branch from 3272ec5 to 969fce3 Compare

December 4, 2023 19:26

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

969fce3

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

Contributor

facebook-github-bot commented Dec 4, 2023

This pull request was exported from Phabricator. Differential Revision: D51374086

joevilches added a commit to joevilches/yoga that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

a355ce6

…book#1484)

Summary:
Pull Request resolved: facebook#1484

X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

fbshipit-source-id: 3c8b83b16886b60e843b7aa867a57da2624ba842

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

843de68

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

8a32d37

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

52c4c05

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

35f27d7

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches force-pushed the export-D51374086 branch from 969fce3 to 9fbdeca Compare

December 5, 2023 21:14

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

9fbdeca

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/yoga that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

bf3788f

…book#1484)

Summary:

X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

Contributor

facebook-github-bot commented Dec 5, 2023

This pull request was exported from Phabricator. Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

9e40a64

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

d3948ad

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

3eb4310

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches force-pushed the export-D51374086 branch from 9fbdeca to 20ceb5c Compare

December 5, 2023 21:56

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

20ceb5c

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

Contributor

facebook-github-bot commented Dec 5, 2023

This pull request was exported from Phabricator. Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

cc2e1b6

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

c29c34d

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/yoga that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

55be53d

…book#1484)

Summary:

X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches force-pushed the export-D51374086 branch from 5ca1d59 to 9f449ab Compare

December 7, 2023 22:02

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

603349d

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

9f449ab

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

c55f586

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

a79095b

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

de53df5

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

Joe Vilches and others added 4 commits

December 7, 2023 14:39


          Make positionAbsoluteChild the sole place that matters when determini…

7343d39

…ng absolute node's position (facebook#41684)

Summary:
X-link: facebook/yoga#1481


Absolute nodes can be laid out by themselves and do not have to care about what is happening to their siblings. Because of this we can make `positionAbsoluteChild` the sole place where we handle this logic. Right now that is scattered around algorithm with many `if (child is absolute)` cases everywhere. This makes implementing position static a lot harder since we are relying on the CB to do all this work, not the parent.

With this change the only time we set position for an absolute node and it matter (i.e. not overwritten) is in `positionAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51290723


          Make position static behave like position static (facebook#41685)

8db640e

Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606


          Fix issue where percentages were off of the border box, not padding b…

d0976f0

…ox (facebook#41686)

Summary:
X-link: facebook/yoga#1485


The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at  `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this.

Added a test that was failing before this change as well

Reviewed By: NickGerleman

Differential Revision: D51330526


          Fix bug with align start not taking into account parent padding (face…

f023d18

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

9c7d92a

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches force-pushed the export-D51374086 branch from 9f449ab to f023d18 Compare

December 7, 2023 22:39

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

628fa90

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/yoga that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

215d8ff

…book#1484)

Summary:

X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

4eee4ba

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

d6dd9be

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

000656c

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

joevilches pushed a commit to joevilches/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

8f2fd43

…book#41687)

Summary:
X-link: facebook/yoga#1484


Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request


          Fix bug with align start not taking into account parent padding

51683e0

Summary:
X-link: facebook/yoga#1484

X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8

facebook-github-bot closed this in

ea3dd6b

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Dec 8, 2023

This pull request has been merged in ea3dd6b.

facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request


          Fix bug with align start not taking into account parent padding (#1484)

d1dda21

Summary:
Pull Request resolved: #1484

X-link: facebook/react-native#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8

Othinn pushed a commit to Othinn/react-native that referenced this pull request


          Fix bug with align start not taking into account parent padding (face…

670f16e

…book#41687)

Summary:
X-link: facebook/yoga#1484

Pull Request resolved: facebook#41687

Tsia. Added test and accounted for parent padding

Reviewed By: NickGerleman

Differential Revision: D51374086

fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner