Fix StrictMode warnings #22186
Labels
Comments
brunolemos
added a commit
to devhubapp/devhub
that referenced
this issue
Nov 10, 2018
kelset
added
Good first issue
|
Will be working on this over the weekend. |
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Converts ScrollView to use constructor instead of UNSAFE_componentWillMount and componentDidUpdate instead of UNSAFE_componentWillReceiveProps. Related to facebook#22186
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Convert all Touchables to be class based and remove UNSAFE props. Also renamed Touchable.Mixin.withoutDefaultFocusAndBlur to Touchable.MixinWithoutDefaultFocusAndBlur to improve flow automatic typings. Note: TouchableNativeFeedback uses ReactNative.findNodeHandle which triggers a warning in strict mode during a tap. I could not figure out how to remove it yet. Related to facebook#22186
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Convert all Touchables to be class based and remove UNSAFE props. Also renamed Touchable.Mixin.withoutDefaultFocusAndBlur to Touchable.MixinWithoutDefaultFocusAndBlur to improve flow automatic typings. Note: TouchableNativeFeedback uses ReactNative.findNodeHandle which triggers a warning in strict mode during a tap. I could not figure out how to remove the need for that call. Related to facebook#22186
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Convert all Touchables to be class based and remove UNSAFE props. Also renamed Touchable.Mixin.withoutDefaultFocusAndBlur to Touchable.MixinWithoutDefaultFocusAndBlur to improve flow automatic typings. Note: TouchableNativeFeedback uses ReactNative.findNodeHandle which triggers a warning in strict mode during a tap. I could not figure out how to remove the need for that call. Related to facebook#22186
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Convert all Touchables to be class based and remove UNSAFE props. Also renamed Touchable.Mixin.withoutDefaultFocusAndBlur to Touchable.MixinWithoutDefaultFocusAndBlur to improve flow automatic typings. Note: TouchableNativeFeedback uses ReactNative.findNodeHandle which triggers a warning in strict mode during a tap. I could not figure out how to remove the need for that call. Related to facebook#22186
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Convert all Touchables to be class based and remove UNSAFE props. Also renamed Touchable.Mixin.withoutDefaultFocusAndBlur to Touchable.MixinWithoutDefaultFocusAndBlur to improve flow automatic typings. Note: TouchableNativeFeedback uses ReactNative.findNodeHandle which triggers a warning in strict mode during a tap. I could not figure out how to remove the need for that call. Related to facebook#22186
Jyrno42
added a commit
to Jyrno42/react-native
that referenced
this issue
Mar 30, 2019
Convert all Touchables to be class based and remove UNSAFE props. Also renamed Touchable.Mixin.withoutDefaultFocusAndBlur to Touchable.MixinWithoutDefaultFocusAndBlur to improve flow automatic typings. Note: TouchableNativeFeedback uses ReactNative.findNodeHandle which triggers a warning in strict mode during a tap. I could not figure out how to remove the need for that call. Related to facebook#22186
|
Opened two PRs for ScrollView and AnimatedComponents/Touchables: |
|
@Jyrno42 I see this is marked as help wanted. A few friends and I, Computer Science students, would love to help with this issue. Please let us know! |
|
@ConnorSBrady Feel free to grab the ScrollView/VirtualizedList - I am currently only working on createAnimatedComponent. |
cpojer
removed
the
Good first issue
|
This is still valid, at least those 2 internal components are using unsafe callbacks:
It looks like |
|
Found another one:
Indeeded |
|
@sammy-SC I am still getting warnings while using animated component in my react-native app while in StrictMode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When wrapping the app with
<StrictMode>, there are warnings coming from internal react native components. They need to be updated to stop using the legacy context api and unsafe methods like UNSAFE_componentWillReceiveProps.Also, I believe this is a prerequisite for Concurrent Mode support.
Environment
Environment
React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
Memory: 33.30 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.11.4 - /usr/local/bin/node
Yarn: 1.10.1 - ~/.yarn/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
Build Tools: 23.0.1, 23.0.3, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.0, 28.0.2, 28.0.3
API Levels: 19, 22, 23, 24, 25, 26, 27, 28
IDEs:
Android Studio: 3.2 AI-181.5540.7.32.5014246
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmGlobalPackages:
react-native-cli: 2.0.1
The text was updated successfully, but these errors were encountered: