Make ScrollView StrictMode compatible #24214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts ScrollView to use constructor instead of UNSAFE_componentWillMount and componentDidUpdate instead of UNSAFE_componentWillReceiveProps. Related to facebook#22186
facebook-github-bot
added
the
CLA Signed
Muffint0p1
approved these changes
Mar 30, 2019
|
Note: The ScrollView uses |
|
Similarly to the other PR, just moving lifecycle functionality to the constructor won't actually fix real issues. We'll need to change this component, possibly to use hooks. Would you be interested in reworking ScrollView with that in mind? Keep in mind that we have to be very careful and do a good amount of testing so we don't break this component. |
|
Got it. I'll try to get animated component one done/merged first, and if anyone else has not grabbed scrollview conversion by then I'll take it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts ScrollView to use constructor instead of UNSAFE_componentWillMount and componentDidUpdate instead of UNSAFE_componentWillReceiveProps.
see #22186
Changelog
[General] [Fixed] - Converted ScrollView to be compatible with StrictMode
Test Plan
Tested manually via RNTester by opening StrictMode example and ensuring no strict-mode warnings are rendered. I also verified in a fresh project that stickyHeaderIndices still works.