Correct logo URL

[gusgard]

Update logo URL
https://facebook.github.io/react/img/logo_og.png (old) to https://facebook.github.io/react/logo-og.png (new)

Test Plan

Check that the old URL shows a "Page Not Found" and the new URL the correct image.

[facebook-github-bot]

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[bvaughn]

FWIW this should probably point to https://reactjs.org/logo-og.png 😄

[elicwhite]

Thanks for contributing!

Feel free to send another PR updating to @bvaughn's recommended URL.

[gusgard]

@TheSavior Sure 👍

[gusgard]

@bvaughn It would be possible to move this files (logo_small.png &
logo_small_2x.png) to the static folder

https://reactjs.org/logo-small.png is not working.

Because is used:

react-native/RNTester/js/ImageExample.js

Line 199 in 2d2dfa2

{uri: 'https://facebook.github.io/react/img/logo_small_2x.png', width: 76, height: 76},

react-native/RNTester/js/ImageExample.js

Line 198 in 2d2dfa2

{uri: 'https://facebook.github.io/react/img/logo_small.png', width: 38, height: 38},

@TheSavior The integration tests fails because of this URL

react-native/IntegrationTests/ImageCachePolicyTest.js

Line 68 in 1e8f3b1

uri: 'https://facebook.github.io/react/img/logo_small_2x.png?cacheBust=notinCache' + Date.now(),

we could use https://reactjs.org/logo-og.png, unless the size of the image is important for the test.

Let me know so I can make the PR 😄

[bvaughn]

Why are react-native integration tests reliant on the react website 😅

Yes, it would be possible to move the image logos to the static folder to be accessible at the URL you describe, but I'm not sure continuing to support that dependency is a good idea to be honest.

[gusgard]

I agree with you, the best could be to have the static files in the web of react-native, like this one (http://facebook.github.io/react-native/img/header_logo.png). Do we have a fancy URL, like https://reactjs.org ?

[bvaughn]

They don't need to be hosted with a fancy URL. They could be loaded:

1. from the github.io website, eg facebook.github.io/react-native/img/header_logo.png, or better yet...
2. directly from GitHub (in a folder beside the test so their use is clear), eg raw.githubusercontent.com/facebook/react-native/master/RNTester/js/hawk.png

Both of these approaches have GitHub infrastructure as a source of failure, but that's true of the old link to the React website as well. At least this would remove an external project dependency.

[gusgard]

Yes, could be a good idea to have all the images used (with URLs) in a folder inside RNTester or IntegrationTests.