set blob as default XMLHttpRequest header response type if supported #22063
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This fixes the quoted issues, i've just patched manually and tested - Please merge |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thank you for sending this PR. It makes me wonder though: what is the reason RN ships with its own copy of fetch? |
…acebook#22063) Summary: This is a problem that is discussed in issue facebook#21092 Related issues: facebook#21851 facebook#19717 Found the code to eventually fix this issue [here](https://github.com/github/fetch/blob/899b155746630c32d83ee29a38642da16b314ecb/fetch.js#L486) - [x] Fetching an image locally and check if the blob is there, as well as its size > 0. ___ Help reviewers and the release process by writing your own release notes. See below for an example. [GENERAL] [ENHANCEMENT] [whatwg-fetch] - set blob as default XMLHttpRequest header response type if supported Pull Request resolved: facebook#22063 Differential Revision: D13408797 Pulled By: cpojer fbshipit-source-id: 9822d5a7e24bacd72838f3fc9a61b1a97b44484b
hramos
removed
Import Started
This is a problem that is discussed in issue #21092
Related issues: #21851 #19717
Found the code to eventually fix this issue here
Test Plan
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [ENHANCEMENT] [whatwg-fetch] - set blob as default XMLHttpRequest header response type if supported