Add Flipper to default template on Android and iOS #27569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
safaiyeh
changed the title
30 tasks
|
Wow this is great! What's the CI failure? |
|
|
@rickhanlonii the failed CI has been a known issue. The master build for that is failing as well. You can cherry pick: RNTester implementation is not consistent with 0.62 implementation. I can update that to match. |
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
rickhanlonii
changed the title
safaiyeh
changed the title
6 tasks
safaiyeh
changed the title
|
I think after #27837, this should be good to go. |
|
Is this good to go now? |
rickhanlonii
changed the title
|
I think so! |
passy
approved these changes
Jan 30, 2020
passy
approved these changes
Jan 30, 2020
|
This pull request was successfully merged by @safaiyeh in 52cd9cd. When will my fix make it into a release? | Upcoming Releases |
rickhanlonii
pushed a commit
that referenced
this pull request
Feb 5, 2020
Summary: Issue: #27565 initalizeFlipper should be set in template app by default. ## Changelog [iOS] [Changed] - Added Flipper to template app [Android] [Changed] - Added Flipper to template app Pull Request resolved: #27569 Test Plan: Connect Flipper to the iOS application Connect Flipper to the Android application Reviewed By: passy Differential Revision: D19344704 Pulled By: rickhanlonii fbshipit-source-id: ca126fd2caab13751ddc2ce6d195bd0c644c704e
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
…7569) Summary: Issue: facebook#27565 initalizeFlipper should be set in template app by default. ## Changelog [iOS] [Changed] - Added Flipper to template app [Android] [Changed] - Added Flipper to template app Pull Request resolved: facebook#27569 Test Plan: Connect Flipper to the iOS application Connect Flipper to the Android application Reviewed By: passy Differential Revision: D19344704 Pulled By: rickhanlonii fbshipit-source-id: ca126fd2caab13751ddc2ce6d195bd0c644c704e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #27565
initalizeFlipper should be set in template app by default.
Changelog
[iOS] [Changed] - Added Flipper to template app
[Android] [Changed] - Added Flipper to template app
Test Plan
Connect Flipper to the iOS application
Connect Flipper to the Android application