-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][template] Upgrade Flipper version #27837
Conversation
Summary: Same steps as in RNTester. Test Plan: react-native init --version 0.62.0-rc.0 Effectively made the same changes as below. Compiles but currently doesn't run because of an unrelated crash: ``` 14:35:54.053 AndroidRuntime FATAL EXCEPTION: mqt_native_modules Process: com.testproj, PID: 29797 java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/swiperefreshlayout/widget/SwipeRefreshLayout; at com.facebook.react.shell.MainReactPackage.createViewManagers(MainReactPackage.java:190) at com.facebook.react.ReactInstanceManager.getOrCreateViewManagers(ReactInstanceManager.java:830) at com.facebook.react.CoreModulesPackage.createUIManager(CoreModulesPackage.java:189) at com.facebook.react.CoreModulesPackage.getModule(CoreModulesPackage.java:157) at com.facebook.react.TurboReactPackage$ModuleHolderProvider.get(TurboReactPackage.java:159) at com.facebook.react.TurboReactPackage$ModuleHolderProvider.get(TurboReactPackage.java:147) at com.facebook.react.bridge.ModuleHolder.create(ModuleHolder.java:191) at com.facebook.react.bridge.ModuleHolder.getModule(ModuleHolder.java:156) at com.facebook.react.bridge.NativeModuleRegistry.getModule(NativeModuleRegistry.java:149) at com.facebook.react.bridge.CatalystInstanceImpl.getNativeModule(CatalystInstanceImpl.java:590) at com.facebook.react.bridge.CatalystInstanceImpl.getNativeModule(CatalystInstanceImpl.java:567) at com.facebook.react.uimanager.UIManagerHelper.getUIManager(UIManagerHelper.java:42) at com.facebook.react.ReactInstanceManager.attachRootViewToInstance(ReactInstanceManager.java:1111) at com.facebook.react.ReactInstanceManager.setupReactContext(ReactInstanceManager.java:1057) at com.facebook.react.ReactInstanceManager.access$1400(ReactInstanceManager.java:132) at com.facebook.react.ReactInstanceManager$5$2.run(ReactInstanceManager.java:1017) at android.os.Handler.handleCallback(Handler.java:883) at android.os.Handler.dispatchMessage(Handler.java:100) at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27) at android.os.Looper.loop(Looper.java:214) at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:226) at java.lang.Thread.run(Thread.java:919) Caused by: java.lang.ClassNotFoundException: Didn't find class "androidx.swiperefreshlayout.widget.SwipeRefreshLayout" on path: DexPathList[[zip file "/data/app/com.testproj-aGTaaMSONCephW7Vd5X-lA==/base.apk"],nativeLibraryDirectories=[/data/app/com.testproj-aGTaaMSONCephW7Vd5X-lA==/lib/x86, /data/app/com.testproj-aGTaaMSONCephW7Vd5X-lA==/base.apk!/lib/x86, /system/lib, /system/product/lib]] at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:196) at java.lang.ClassLoader.loadClass(ClassLoader.java:379) at java.lang.ClassLoader.loadClass(ClassLoader.java:312) ... 22 more ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @passy in 939df8a. When will my fix make it into a release? | Upcoming Releases |
Summary: Depends on #27833. Updates the Flipper version to the most recent release. ## Changelog [Android] [Changed] - Upgrade Flipper version in default template Pull Request resolved: #27837 Test Plan: This is a bit annoying, but I can't test this against the 0.62-rc.0 version. I tried patching it by running `react-native init --version 0.62.0-rc.0 testproj`, which would fail because of a missing androidx dep. After adding `implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.0.0'` to the deps, that was fixed but now after updating, `libfbjni.so` is missing because my PR #27729 isn't part of the RN dependency yet. Given that this mirrors the RNTester app, I'm pretty confident that the change here is otherwise correct and will work on top of master with the most recent template changes. Differential Revision: D19619365 Pulled By: passy fbshipit-source-id: 5723bd105ab3ab86b7f00e1a26e29e1e9dc58290
Summary: Depends on facebook#27833. Updates the Flipper version to the most recent release. ## Changelog [Android] [Changed] - Upgrade Flipper version in default template Pull Request resolved: facebook#27837 Test Plan: This is a bit annoying, but I can't test this against the 0.62-rc.0 version. I tried patching it by running `react-native init --version 0.62.0-rc.0 testproj`, which would fail because of a missing androidx dep. After adding `implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.0.0'` to the deps, that was fixed but now after updating, `libfbjni.so` is missing because my PR facebook#27729 isn't part of the RN dependency yet. Given that this mirrors the RNTester app, I'm pretty confident that the change here is otherwise correct and will work on top of master with the most recent template changes. Differential Revision: D19619365 Pulled By: passy fbshipit-source-id: 5723bd105ab3ab86b7f00e1a26e29e1e9dc58290
Depends on #27833.
Summary
Updates the Flipper version to the most recent release.
Changelog
[Android] [Changed] - Upgrade Flipper version in default template
Test Plan
This is a bit annoying, but I can't test this against the 0.62-rc.0 version. I tried patching it by running
react-native init --version 0.62.0-rc.0 testproj
, which would fail because of a missing androidx dep. After addingimplementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.0.0'
to the deps, that was fixed but now after updating,libfbjni.so
is missing because my PR #27729 isn't part of the RN dependency yet.Given that this mirrors the RNTester app, I'm pretty confident that the change here is otherwise correct and will work on top of master with the most recent template changes.