-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode support for RCTPerfMonitor #28130
Conversation
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
RNTester.app (iOS): 10657792 bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might work well in Dark Mode, but I suspect it breaks Light Mode. Can you use semantic colors instead? Here's a quick guide I've referred to in the past: https://nshipster.com/dark-mode/
hi @hramos , thanks for taking a time to review this. by reverting my commits and add if (@available(iOS 13.0, *)) {
_container.backgroundColor = UIColor.systemBackgroundColor;
} is this okay ? |
hi @hramos , i have reverted my previous commits and only set the root container of |
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
RNTester.app (iOS): 10657792 bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This looks good! Thanks for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Although this probably breaks anything pre iOS13. When I land it, I'll add another background color for that. |
@PeteTheHeat thanks for taking a time to review this :) about worrying about breaking pre iOS 13, i think it should be fine since wrapped the background colour with |
But that line adding white background color was important. After this diff, on iOS 12, the background color will be transparent. I'm thinking:
|
@PeteTheHeat , ohh yeah sure i will push it right now |
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
RNTester.app (iOS): 10657792 bytes |
This pull request was successfully merged by @gorhom in 576ddfb. When will my fix make it into a release? | Upcoming Releases |
Summary: Hi There 👋, While I'm developing on iOS with dark appearance enabled, i notice that `Pref Monitor` view doesn't support dark mode yet, so here is the PR to fix it :) ## Changelog [iOS] [Fixed] - Fix Pref Monitor in dark appearance Pull Request resolved: facebook#28130 Test Plan: Run any React Native app on iOS > Turn on dark appearance ### Before ![Before](https://user-images.githubusercontent.com/4061838/74872974-8b75b600-535e-11ea-8550-763a598547ec.png) ### After ![After](https://user-images.githubusercontent.com/4061838/74872978-8ca6e300-535e-11ea-9862-4d3014e849f7.png) Reviewed By: RSNara Differential Revision: D20080019 Pulled By: PeteTheHeat fbshipit-source-id: 9365daa3f7193a11760bc1372b8de2c3896def5c
Summary: Hi There 👋, While I'm developing on iOS with dark appearance enabled, i notice that `Pref Monitor` view doesn't support dark mode yet, so here is the PR to fix it :) ## Changelog [iOS] [Fixed] - Fix Pref Monitor in dark appearance Pull Request resolved: facebook#28130 Test Plan: Run any React Native app on iOS > Turn on dark appearance ### Before ![Before](https://user-images.githubusercontent.com/4061838/74872974-8b75b600-535e-11ea-8550-763a598547ec.png) ### After ![After](https://user-images.githubusercontent.com/4061838/74872978-8ca6e300-535e-11ea-9862-4d3014e849f7.png) Reviewed By: RSNara Differential Revision: D20080019 Pulled By: PeteTheHeat fbshipit-source-id: 9365daa3f7193a11760bc1372b8de2c3896def5c
Summary
Hi There 👋,
While I'm developing on iOS with dark appearance enabled, i notice that
Pref Monitor
view doesn't support dark mode yet, so here is the PR to fix it :)Changelog
[iOS] [Fixed] - Fix Pref Monitor in dark appearance
Test Plan
Run any React Native app on iOS > Turn on dark appearance
Before
After