Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode support for RCTPerfMonitor #28130

Closed
wants to merge 8 commits into from
Closed

Dark mode support for RCTPerfMonitor #28130

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d4f8a1
chore: set labels color to black in perf monitor view
gorhom Feb 19, 2020
ca3578e
chore: set metrics tableview background color to white
gorhom Feb 19, 2020
7031c59
chore: update metrics cell background and label colors
gorhom Feb 19, 2020
1940ba7
Revert "chore: set metrics tableview background color to white"
gorhom Feb 20, 2020
d45e12c
Revert "chore: set labels color to black in perf monitor view"
gorhom Feb 20, 2020
4d9c04b
Revert "chore: update metrics cell background and label colors"
gorhom Feb 20, 2020
3d37401
chore: perf monitor root background to systemBackgroundColor
gorhom Feb 20, 2020
c5e7e39
fix: fixed RCTPerfMonitor container background for pre-iOS 13
gorhom Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions React/CoreModules/RCTFPSGraph.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ - (UILabel *)label
_label = [[UILabel alloc] initWithFrame:self.bounds];
_label.font = [UIFont boldSystemFontOfSize:13];
_label.textAlignment = NSTextAlignmentCenter;
_label.textColor = UIColor.blackColor;
}

return _label;
Expand Down
8 changes: 8 additions & 0 deletions React/CoreModules/RCTPerfMonitor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ - (UILabel *)memory
_memory.font = [UIFont systemFontOfSize:12];
_memory.numberOfLines = 3;
_memory.textAlignment = NSTextAlignmentCenter;
_memory.textColor = UIColor.blackColor;
}

return _memory;
Expand All @@ -227,6 +228,7 @@ - (UILabel *)heap
_heap.font = [UIFont systemFontOfSize:12];
_heap.numberOfLines = 3;
_heap.textAlignment = NSTextAlignmentCenter;
_heap.textColor = UIColor.blackColor;
}

return _heap;
Expand All @@ -239,6 +241,7 @@ - (UILabel *)views
_views.font = [UIFont systemFontOfSize:12];
_views.numberOfLines = 3;
_views.textAlignment = NSTextAlignmentCenter;
_views.textColor = UIColor.blackColor;
}

return _views;
Expand Down Expand Up @@ -269,6 +272,7 @@ - (UILabel *)uiGraphLabel
_uiGraphLabel.font = [UIFont systemFontOfSize:11];
_uiGraphLabel.textAlignment = NSTextAlignmentCenter;
_uiGraphLabel.text = @"UI";
_uiGraphLabel.textColor = UIColor.blackColor;
}

return _uiGraphLabel;
Expand All @@ -281,6 +285,7 @@ - (UILabel *)jsGraphLabel
_jsGraphLabel.font = [UIFont systemFontOfSize:11];
_jsGraphLabel.textAlignment = NSTextAlignmentCenter;
_jsGraphLabel.text = @"JS";
_jsGraphLabel.textColor = UIColor.blackColor;
}

return _jsGraphLabel;
Expand All @@ -297,6 +302,7 @@ - (UITableView *)metrics
)];
_metrics.dataSource = self;
_metrics.delegate = self;
_metrics.backgroundColor = UIColor.whiteColor;
_metrics.autoresizingMask = UIViewAutoresizingFlexibleHeight | UIViewAutoresizingFlexibleWidth;
[_metrics registerClass:[UITableViewCell class] forCellReuseIdentifier:RCTPerfMonitorCellIdentifier];
}
Expand Down Expand Up @@ -565,6 +571,8 @@ - (UITableViewCell *)tableView:(UITableView *)tableView

cell.textLabel.text = _perfLoggerMarks[indexPath.row];
cell.textLabel.font = [UIFont systemFontOfSize:12];
cell.textLabel.textColor = UIColor.blackColor;
cell.backgroundColor = UIColor.whiteColor;

return cell;
}
Expand Down