Platform: Implement Platform.isCatalyst

[charpeni]

Summary

Following up on #27484, instead of adding Platform.isMac this pull request is proposing Platform.isCatalyst to avoid a collision with react-native-macos.

⚠️ Note that Platform.OS is still returning ios, even on macOS with Catalyst.

In the meantime, you can rely on react-native-is-catalyst as an external dependency.

Changelog

[General] [Added] - Implement Platform.isCatalyst to know if we're running on macOS with Catalyst.

Test Plan

macOS	iOS

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: a315e4c

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,211,137	60
android	hermes	armeabi-v7a	6,860,309	60
android	hermes	x86	7,645,773	68
android	hermes	x86_64	7,536,709	52
android	jsc	arm64-v8a	9,370,062	16
android	jsc	armeabi-v7a	9,011,366	12
android	jsc	x86	9,232,786	8
android	jsc	x86_64	9,809,926	8

Base commit: a315e4c

[elicwhite]

cc @appden @alloy

[alloy]

I feel like the function doesn’t add much and the check could simply be inlined, but I assume the compiler will optimise it that way so it’s mostly a stylistic choice 🤷‍♂️

[appden]

I'd prefer this to called isMacCatalyst() as it's more clear and more inline with how Apple markets the technology.

My general concern is that this will force all platforms to implement a isMacCatalyst() method, which is very specific, so I wonder if we should instead go with a method called isDesktop() to be more inclusive for our other platforms. That way react-native-macos and react-native-windows can return true for this method as well.

Thoughts @alloy?

[alloy]

I like that, I’m just a little concerned about the boundaries. Would this return true on iPad OS or what is the definition of a desktop machine?

[appden]

No, the purpose is it would return true for macOS (AppKit or UIKit) and Windows. 😄

Although lots of people use iPad as a desktop, I think the general expectation is that it is not classified as a desktop. If that's a controversial opinion, then we can consider another name. We already have isPad() and isTV() methods that describe the type of device rather than particular OS, so I think isDesktop() would fit nicely in there.

[alloy]

Yeah, perhaps desktops and iPads together are ‘workstations’? In any case, seems like we have enough ways to narrow down the type, so I’m good with ‘desktop’ 👍

[byteab]

why not just include it inside Platform.OS

[charpeni]

@EhsanSarshar because Mac Catalyst isn't a platform itself, it's running the iOS app on macOS, so its behavior should mostly follow iOS except for some cases where we want it to be desktop.

Also, Platform.OS is handled by the packager (Metro) during build time, not here in React Native. See this PR for the implementation of Platform.select with mac: facebook/metro#495.

[alloy]

@charpeni Will you update this to be isDesktop?

[charpeni]

Will do!

[marcosrdz]

Any updates on this? This is a great enhancement

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.