Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultProps in SegmentedControlIOS #31604 #31751

Conversation

Damoness
Copy link

Summary

remove defaultProps from SegmentedControlIOS

Changelog

[JavaScript] [changed] - defaultProps are removed in SegmentedControlIOS

Test Plan

all test suite and CI passes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,153,806 +0
android hermes armeabi-v7a 8,687,309 +0
android hermes x86 9,594,565 +0
android hermes x86_64 9,562,743 +0
android jsc arm64-v8a 10,798,082 +0
android jsc armeabi-v7a 9,722,858 +0
android jsc x86 10,834,239 +0
android jsc x86_64 11,443,925 +0

Base commit: 006f5af

@yungsters yungsters self-assigned this Jul 30, 2021
@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yungsters
Copy link
Contributor

Actually, #31804 did this (and with tests).

@yungsters yungsters closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants