-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defaultProps from SegmentedControlIOS #31804
Closed
daschaa
wants to merge
4
commits into
facebook:master
from
daschaa:fix/31604_segmentedcontrolios_default_props
Closed
Remove defaultProps from SegmentedControlIOS #31804
daschaa
wants to merge
4
commits into
facebook:master
from
daschaa:fix/31604_segmentedcontrolios_default_props
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 2, 2021
Base commit: ca440b9 |
Base commit: ca440b9 |
lunaleaps
requested changes
Jul 9, 2021
Libraries/Components/SegmentedControlIOS/SegmentedControlIOS.ios.js
Outdated
Show resolved
Hide resolved
lunaleaps
reviewed
Jul 9, 2021
Libraries/Components/SegmentedControlIOS/__tests__/SegmentedContolIOS-test.js
Show resolved
Hide resolved
lunaleaps
approved these changes
Jul 11, 2021
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@lunaleaps merged this pull request in fa0518d. |
Thanks @joxw1 for your help!! I modified slightly the prop values from an internal review to make things simpler since we're only using these props in one place. Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Needs: React Native Team Attention
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #31604 . Remove
defaultProps
fromSegmentedControlIOS
.Changelog
[JavaScript] [Changed] - Remove defaultProps from SegmentedControlIOS
Test Plan
Added tests for
SegmentedControlIOS
pass.