Remove BitUtils Usage in YGNode #36988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 19, 2023
Summary: X-link: facebook/react-native#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct. Differential Revision: D45133645 fbshipit-source-id: 7e4e8c78220165e4e9678c4b0b1f8f26a6c74d2a
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
force-pushed
the
export-D45133645
branch
from
e9cc8fa to
a0c4175
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: d69ec8829e5cb6763da7a3a65f1bbbf1a145f20f
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133645 fbshipit-source-id: a0a86e0277d0f4f43d58b8bc3fa96fc7cf61aad0
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
force-pushed
the
export-D45133645
branch
from
a0c4175 to
e7a217a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: ce282d670277b514c0876d0d91372b9a22471601
NickGerleman
force-pushed
the
export-D45133645
branch
from
e7a217a to
86b943e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: 4b6e4f83fe226304d33cb06cef03a77dd4bd455e
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
force-pushed
the
export-D45133645
branch
from
86b943e to
533a3e9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: e8efdedccf0ce662e6917ced8cefec8fabffc387
NickGerleman
force-pushed
the
export-D45133645
branch
from
533a3e9 to
478aed3
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: 8b6cca5cb0d5eebf17ce280000835228f7f1064f
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
force-pushed
the
export-D45133645
branch
from
478aed3 to
bb0c64b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: d69da5ab0a5896309d33be1206a4c6756ac79c43
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
force-pushed
the
export-D45133645
branch
from
bb0c64b to
3bc7da2
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Differential Revision: D45133645 fbshipit-source-id: ec836ead6055df7b048d4258f9a0a3c5ab311fe8
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
force-pushed
the
export-D45133645
branch
from
3bc7da2 to
5350482
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133645 fbshipit-source-id: 55ed806393ffeda5e27ca9a9856315620bd718aa
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 20, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct. Changelog: [Internal] Differential Revision: https://internalfb.com/D45133645 fbshipit-source-id: 56bd37c7e507f9172437a88772d142edede52f9d
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133645 fbshipit-source-id: f2df7821305214ad3abb38727af6cd9e9d8515b4
NickGerleman
force-pushed
the
export-D45133645
branch
from
5350482 to
0010b58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45133645 |
Base commit: 65f5cd7 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Apr 21, 2023
Summary: Pull Request resolved: #1250 X-link: facebook/react-native#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133645 fbshipit-source-id: aa1430df5e2fb71ed9d2a5f5b1a35429b71c7069
|
This pull request has been merged in 4ae77c0. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 21, 2023
Summary: X-link: facebook/yoga#1250 X-link: facebook/react-native#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133645 fbshipit-source-id: aa1430df5e2fb71ed9d2a5f5b1a35429b71c7069
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133645 fbshipit-source-id: aa1430df5e2fb71ed9d2a5f5b1a35429b71c7069
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: X-link: facebook/yoga#1250 Pull Request resolved: facebook#36988 BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133645 fbshipit-source-id: aa1430df5e2fb71ed9d2a5f5b1a35429b71c7069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct.
Differential Revision: D45133645