Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish rn-tester apks and bundle to build artifacts #1250

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

rasaha91
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

To simplify our validation process, we are publishing rn-tester apks and bundles to build artifacts, so that we can test without having to perform a build.

Changelog

[Android] [Internal] - Publish rn-tester apks and bundle to build artifacts

Test Plan

Verify the PR pipeline succeeds

@rasaha91 rasaha91 requested review from a team as code owners July 11, 2022 17:09
@pull-bot
Copy link

Fails
🚫

node failed.

Log

Error:  RequestError [HttpError]: Must have admin rights to Repository.
    at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5) {
  status: 403,
  response: {
    url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1250/labels',
    status: 403,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      connection: 'close',
      'content-encoding': 'gzip',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Mon, 11 Jul 2022 17:13:08 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'GitHub.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-accepted-oauth-scopes': '',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': 'A2AA:33D4:2A3373:55CEA2:62CC5A24',
      'x-oauth-scopes': 'public_repo',
      'x-ratelimit-limit': '5000',
      'x-ratelimit-remaining': '4992',
      'x-ratelimit-reset': '1657563186',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '8',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Must have admin rights to Repository.',
      documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
    }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1250/labels',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"labels":["Pick Request"]}',
    request: { hook: [Function: bound bound register] }
  }
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 214e540

@rasaha91 rasaha91 enabled auto-merge July 11, 2022 18:33
@rasaha91 rasaha91 merged commit 7afb6fa into microsoft:0.68-stable Jul 11, 2022
rasaha91 added a commit to rasaha91/react-native-macos that referenced this pull request Jul 12, 2022
…acts

Publish rn-tester apks and bundle to build artifacts
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: d69ec8829e5cb6763da7a3a65f1bbbf1a145f20f
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D45133645

fbshipit-source-id: a0a86e0277d0f4f43d58b8bc3fa96fc7cf61aad0
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: ce282d670277b514c0876d0d91372b9a22471601
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: 4b6e4f83fe226304d33cb06cef03a77dd4bd455e
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: e8efdedccf0ce662e6917ced8cefec8fabffc387
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: 8b6cca5cb0d5eebf17ce280000835228f7f1064f
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: d69da5ab0a5896309d33be1206a4c6756ac79c43
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Differential Revision: D45133645

fbshipit-source-id: ec836ead6055df7b048d4258f9a0a3c5ab311fe8
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D45133645

fbshipit-source-id: 55ed806393ffeda5e27ca9a9856315620bd718aa
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets). Replace usage with a bitfield struct.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D45133645

fbshipit-source-id: 56bd37c7e507f9172437a88772d142edede52f9d
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 20, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D45133645

fbshipit-source-id: f2df7821305214ad3abb38727af6cd9e9d8515b4
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 21, 2023
Summary:
X-link: facebook/yoga#1250

Pull Request resolved: facebook#36988

BitUtils functions in Yoga are like bit fields, with more steps, and more error prone (you need to work with explicit offsets which can be tricky for anything variable length). Replace usage with a bitfield struct. Eventually I'd like to remove the BitUtils functions in general.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D45133645

fbshipit-source-id: aa1430df5e2fb71ed9d2a5f5b1a35429b71c7069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants