Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lazy bundling in dev on iOS/Android #37003

Closed
wants to merge 1 commit into from

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Apr 20, 2023

Summary:
Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables lazy bundling when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43600054

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43600054

motiz88 added a commit to motiz88/react-native that referenced this pull request Apr 20, 2023
Summary:
Pull Request resolved: facebook#37003

Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (TODO: add PR number for OSS) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

fbshipit-source-id: 35ebc6d9425941c3e89bb75eaa895d75be3cb2ca
motiz88 added a commit to motiz88/react-native that referenced this pull request Apr 20, 2023
Summary:
Pull Request resolved: facebook#37003

Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (TODO: add PR number for OSS) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

fbshipit-source-id: 924ef979a694eb3b1f6cd2796ca85687940ae2b6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43600054

@analysis-bot
Copy link

analysis-bot commented Apr 20, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,622,813 +9
android hermes armeabi-v7a 7,936,181 +23
android hermes x86 9,109,461 +8
android hermes x86_64 8,964,486 +12
android jsc arm64-v8a 9,187,084 +30
android jsc armeabi-v7a 8,377,958 +28
android jsc x86 9,245,137 +26
android jsc x86_64 9,503,791 +17

Base commit: 28d5c15
Branch: main

motiz88 added a commit to motiz88/react-native that referenced this pull request Apr 21, 2023
Summary:
Pull Request resolved: facebook#37003

Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

fbshipit-source-id: db0292a1b33ff1a7b14ba7f9523ccbed23783a06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43600054

Summary:
Pull Request resolved: facebook#37003

Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

fbshipit-source-id: b7592c452520ade4e5ff9ee0fa0742189625b390
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43600054

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e66bdf0.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#37003

Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

fbshipit-source-id: 515e2180a2130fd1a75e53677e789d31a367f7c2
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#37003

Changelog: [General][Added] [3/n] Support lazy bundling in development

Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro.

NOTE: This depends on a Metro diff (facebook/metro#971) that hasn't landed yet, but is a no-op until then.

Reviewed By: jacdebug

Differential Revision: D43600054

fbshipit-source-id: 515e2180a2130fd1a75e53677e789d31a367f7c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants