Enable lazy bundling in dev on iOS/Android (facebook#37003)

Summary: Pull Request resolved: facebook#37003 Changelog: [General][Added] [3/n] Support lazy bundling in development Enables [lazy bundling](https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0605-lazy-bundling.md) when requesting a development bundle from Metro. NOTE: This depends on a Metro diff (TODO: add PR number for OSS) that hasn't landed yet, but is a no-op until then. Reviewed By: jacdebug Differential Revision: D43600054 fbshipit-source-id: 35ebc6d9425941c3e89bb75eaa895d75be3cb2ca
motiz88 · Apr 20, 2023 · 5efaa65 · 5efaa65
1 parent f84256a
commit 5efaa65
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/react-native/React/Base/RCTBundleURLProvider.mm b/packages/react-native/React/Base/RCTBundleURLProvider.mm
@@ -265,10 +265,11 @@ + (NSURL *)jsBundleURLForBundleRoot:(NSString *)bundleRoot
                           runModule:(BOOL)runModule
 {
   NSString *path = [NSString stringWithFormat:@"/%@.bundle", bundleRoot];
-
+  BOOL lazy = enableDev;
   // When we support only iOS 8 and above, use queryItems for a better API.
-  NSString *query = [NSString stringWithFormat:@"platform=ios&dev=%@&minify=%@&modulesOnly=%@&runModule=%@",
+  NSString *query = [NSString stringWithFormat:@"platform=ios&dev=%@&lazy=%@&minify=%@&modulesOnly=%@&runModule=%@",
                                                enableDev ? @"true" : @"false",
+                                               lazy ? @"true" : @"false",
                                                enableMinification ? @"true" : @"false",
                                                modulesOnly ? @"true" : @"false",
                                                runModule ? @"true" : @"false"];

diff --git a/...eact-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java b/...eact-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java
@@ -345,13 +345,16 @@ private String createSplitBundleURL(String mainModuleID, String host) {
 
   private String createBundleURL(
       String mainModuleID, BundleType type, String host, boolean modulesOnly, boolean runModule) {
+    boolean dev = getDevMode();
+    boolean lazy = dev;
     return String.format(
         Locale.US,
-        "http://%s/%s.%s?platform=android&dev=%s&minify=%s&app=%s&modulesOnly=%s&runModule=%s",
+        "http://%s/%s.%s?platform=android&dev=%s&lazy=%s&minify=%s&app=%s&modulesOnly=%s&runModule=%s",
         host,
         mainModuleID,
         type.typeID(),
-        getDevMode(),
+        dev,
+        lazy,
         getJSMinifyMode(),
         mPackageName,
         modulesOnly ? "true" : "false",