Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test runtime lifecycle callback #37897

Closed
wants to merge 7 commits into from
Closed

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Jun 14, 2023

Summary:
Changelog: [Internal]

adding unit test for instance:didInitializeRuntime

Reviewed By: cipolleschi

Differential Revision: D46704036

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46704036

@analysis-bot
Copy link

analysis-bot commented Jun 14, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,668 -2
android hermes armeabi-v7a 8,070,234 -2
android hermes x86 9,250,263 -1
android hermes x86_64 9,099,402 -3
android jsc arm64-v8a 9,318,868 -3
android jsc armeabi-v7a 8,508,771 -1
android jsc x86 9,382,359 -4
android jsc x86_64 9,635,605 -1

Base commit: b0485be
Branch: main

philIip and others added 7 commits June 14, 2023 15:36
Differential Revision: D46547012

fbshipit-source-id: b645dbba698d522958959b68272d4071a1ae5b74
Differential Revision: D46625916

fbshipit-source-id: a1e3204f78503a87a6b9f856e82564d21532d1ee
Differential Revision: D46625917

fbshipit-source-id: 1ca0ffa02b9478a2de7f453faf6fb5cb5fe1cf2a
Differential Revision: D46672230

fbshipit-source-id: 7db8d21a9f3b9b934c40a1417e0944f923d13844
Differential Revision: D46672345

fbshipit-source-id: 9bc70ef21a12e0827f14690975f4f6c47b14dc5d
Differential Revision: D46672582

fbshipit-source-id: fd9d28259f14d222d8664f670435b18a3213c99c
Summary:
Pull Request resolved: facebook#37897

Changelog: [Internal]

adding unit test for `instance:didInitializeRuntime`

Reviewed By: cipolleschi

Differential Revision: D46704036

fbshipit-source-id: 409ee42da3bd220e131a4f770e46753275befef3
@philIip philIip force-pushed the export-D46704036 branch from ad89e66 to 432433a Compare June 14, 2023 22:39
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46704036

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0f688dc.

adamaveray added a commit to adamaveray/react-native that referenced this pull request Jun 16, 2023
* main: (135 commits)
  translation auto-update for i18n/twilight.config.json on master
  Interop: Introduce Bridge proxy
  Remove okhttp internal util usage (facebook#37843)
  Update debian to fix CI while updating Node (facebook#37841)
  fix: foreground ripple crash on api < 23 (facebook#37901)
  Re-add the top level LICENSE file (facebook#37916)
  Deploy 0.209.0 to xplat (facebook#37921)
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914)
  add emitObjectProp in parser primitives (facebook#37904)
  Make React-utils its own pod (facebook#37659)
  feat: allow custom assignment of rootView to rootViewController (facebook#37873)
  Switch xplat prettier config to hermes plugin (facebook#37915)
  Set iOS AppState to inactive when app is launching (facebook#37690)
  Use `fileExists` in replace_hermes script (facebook#37911)
  (docs): fix license url (facebook#37909)
  Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874)
  Fix component type references in xplat (facebook#37903)
  Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867)
  test runtime lifecycle callback (facebook#37897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants