fix: foreground ripple crash on api < 23 #37901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: b0485be |
|
I think this works, but we could also fix on the native side so that any usage of the prop no-ops without adding a check on the JS side. |
I can do that, but it probably shouldn't be a noop - if foreground is not supported, it should fall back to using background ripple? |
|
Oh, yes, I missed that the JS was changing to a specific fallback behavior. JS side solution makes sense to me then. |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @vonovak in ca65d97. When will my fix make it into a release? | Upcoming Releases |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 16, 2023
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
kacperkapusciak
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Aug 1, 2023
Please provide enough information so that others can review your pull request. **Motivation** closes #9794 also observed that the ripple radius can be very slightly increased to be like in the native android toolbar why the `foreground` isn't simply `true`? see facebook/react-native#37901 **Test plan** tested locally
kacperkapusciak
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Aug 1, 2023
Please provide enough information so that others can review your pull request. **Motivation** closes #9794 also observed that the ripple radius can be very slightly increased to be like in the native android toolbar why the `foreground` isn't simply `true`? see facebook/react-native#37901 **Test plan** tested locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Pressable component supports the
foregroundoption for ripple. However, using it on old android api levels (e.g. android 5) crashes withTouchableNativeFeedback.js has a check to make sure this does not happen as seen here
I also want to point out that this PR can be closed #30466 as it's already implemented
Changelog:
Test Plan:
tested locally on another project because I wasn't able to get RN tester running