Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Style enums 12/N: PositionType #39538

Closed
wants to merge 5 commits into from
Closed

C++ Style enums 12/N: PositionType #39538

wants to merge 5 commits into from

Conversation

NickGerleman
Copy link
Contributor

Summary:
X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
d27de00 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: d604b3ce2b5637d7b129f7ef25b42c097d523958
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
5573262 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 9498c42b28f8278e39b4c9a45987c16b4f781960
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
856b38b 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 11d6c74c788b4656865d3bf553f3dc5bf44d6fb5
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
a64d170 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 1e48893232fe06db8ce1eda11b3bb3f3cf78da19
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
c309993 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 196d0ef391ebbcc06e776c04584aa265635a2956
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
b2fa09a 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 80944fdbceee46fbbd197e0b6536fe248b1737bc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
656b40f 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: eb00e74ad822f11f3fbbc170d345b0f1d406e505
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
cf9a46e 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: b199d2ea5928a2f4565642615962faa5666bf428
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
53e5697 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 30524ff5dea3d690bded3450834e00ca848a9035
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
85bbe89 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: e7436c7c0b66a96498d30541783a45cde34c8505
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
68f02da 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 55edd5dcc209f7cca380f15751bdbc8e89ab5b66
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
711013a 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: dc3b8c88a68a796b471512c4e5c970db083c9096
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
76a6916 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 5bf1e95e4f214acefc243d5ba3875da3117869bb
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
b892772 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 49bea8b170e3dbbf06d6b7dae40e2af2ea15be6d
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
d98d0c5 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 690bbbb227138b9102ffed18bd8d215ba2fd3927
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
18913ae 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: fabd653538b5cb9d49072ea0098ac356a53f6602
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
86653fa 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: e0295b3a7f125d18b8fe79c8a885afd45ae9f3ae
@analysis-bot
Copy link

analysis-bot commented Sep 19, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,333,774 +3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,573,322 +56
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 95fb448
Branch: main

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
79fdac7 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: d1b059314eb880c3cdaa4caf2ccee030b07a32c4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
c53b402 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 485e5a2e39ab9235ac207bf4930e648f1635fdef
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
d76d65b 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 63c8c63b34415cc29426b65126c2d5759e0b8d11
NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
595b1f0 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: f1948198aece270de368d9979dc81058e6bee7de
NickGerleman and others added 5 commits September 19, 2023 11:23
@NickGerleman @facebook-github-bot
C++ style enums 8/N: Direction
b5af17d 
Summary: Moves internal usages of YGDirection to Direction.

Differential Revision: D49335231

fbshipit-source-id: 558b1e0452ad46e3c21d0afdbb9854e79f33da5d
@NickGerleman @facebook-github-bot
C++ style enums 9/N: FlexDirection
0818c1f 
Summary: Moves internal usages of YGDirection to Direction.

Differential Revision: https://www.internalfb.com/diff/D49336066?entry_point=27

fbshipit-source-id: 3554772d83aa352fdbf006b73b03c1b698ff4d3e
@NickGerleman @facebook-github-bot
C++ style enums 10/N: Justify
50cb932 
Summary: Moves internal usages of YGJustify to Justify.

Differential Revision: https://internalfb.com/D49336538

fbshipit-source-id: 4c6427b0a3018e5c6ed32fcc61fd960c2cf17bdb
@NickGerleman @facebook-github-bot
C++ style enums 11/N: Align
cc7d08a 
Summary:
Moves internal usages of YGAlign to Align

Changelog: [Internal]

Differential Revision: https://internalfb.com/D49337511

fbshipit-source-id: be39fac22dcb0565804d6f57dcb583123d27dcc6
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#39538)
b2eb950 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: deec3f83dc63483501b4619eaf0ec47f8568e8d0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49361677

NickGerleman added a commit to NickGerleman/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (facebook#1399)
6aa62f0 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: facebook#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 4a83d7ffc21db577acf44f81da6ab10b37aaf0c8
@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against d76d65b

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType
c9f66bd 
Summary:
X-link: facebook/react-native#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 526222d6cf9f3dc26eddfbfb8a04de4ba28e14a9
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Sep 19, 2023
@NickGerleman @facebook-github-bot
C++ Style enums 12/N: PositionType (#1399)
4ea6b4c 
Summary:
X-link: facebook/react-native#39538

Pull Request resolved: #1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 526222d6cf9f3dc26eddfbfb8a04de4ba28e14a9
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in aa8caf0.

ShevO27 pushed a commit to ShevO27/react-native that referenced this pull request Sep 26, 2023
@NickGerleman @ShevO27
C++ Style enums 12/N: PositionType (facebook#39538)
6b4e476 
Summary:
Pull Request resolved: facebook#39538

X-link: facebook/yoga#1399

Moves internal usages of YGPositionType to PositionType

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49361677

fbshipit-source-id: 526222d6cf9f3dc26eddfbfb8a04de4ba28e14a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickGerleman @facebook-github-bot @analysis-bot