C++ Style enums 12/N: PositionType #1399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: f1e94108bc9c6fb8dcd55871f95b0ef0168dba4a
NickGerleman
force-pushed
the
export-D49361677
branch
from
84a65a7
to
d36bfab
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 0d176d8bacae3e6430154edd725a34c638d2cf5d
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: d604b3ce2b5637d7b129f7ef25b42c097d523958
NickGerleman
force-pushed
the
export-D49361677
branch
from
d36bfab
to
d27de00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 9498c42b28f8278e39b4c9a45987c16b4f781960
NickGerleman
force-pushed
the
export-D49361677
branch
from
d27de00
to
5573262
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 11d6c74c788b4656865d3bf553f3dc5bf44d6fb5
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 1e48893232fe06db8ce1eda11b3bb3f3cf78da19
NickGerleman
force-pushed
the
export-D49361677
branch
from
5573262
to
a64d170
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 196d0ef391ebbcc06e776c04584aa265635a2956
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 80944fdbceee46fbbd197e0b6536fe248b1737bc
NickGerleman
force-pushed
the
export-D49361677
branch
from
a64d170
to
b2fa09a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: eb00e74ad822f11f3fbbc170d345b0f1d406e505
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: b199d2ea5928a2f4565642615962faa5666bf428
NickGerleman
force-pushed
the
export-D49361677
branch
from
b2fa09a
to
cf9a46e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 30524ff5dea3d690bded3450834e00ca848a9035
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: e7436c7c0b66a96498d30541783a45cde34c8505
NickGerleman
force-pushed
the
export-D49361677
branch
from
cf9a46e
to
85bbe89
Compare
NickGerleman
force-pushed
the
export-D49361677
branch
from
01d4e05
to
d98d0c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: fabd653538b5cb9d49072ea0098ac356a53f6602
NickGerleman
force-pushed
the
export-D49361677
branch
from
d98d0c5
to
18913ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: e0295b3a7f125d18b8fe79c8a885afd45ae9f3ae
NickGerleman
force-pushed
the
export-D49361677
branch
from
18913ae
to
86653fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: d1b059314eb880c3cdaa4caf2ccee030b07a32c4
NickGerleman
force-pushed
the
export-D49361677
branch
from
86653fa
to
79fdac7
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 485e5a2e39ab9235ac207bf4930e648f1635fdef
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 63c8c63b34415cc29426b65126c2d5759e0b8d11
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: f1948198aece270de368d9979dc81058e6bee7de
NickGerleman
force-pushed
the
export-D49361677
branch
from
79fdac7
to
595b1f0
Compare
Summary: Moves internal usages of YGDirection to Direction. Differential Revision: D49335231 fbshipit-source-id: a18ba80725553694f89f661733f3f246b62d0240
Summary: Moves internal usages of YGDirection to Direction. Differential Revision: https://www.internalfb.com/diff/D49336066?entry_point=27 fbshipit-source-id: abccc7ca3afaaebf4f5a6b23dea89d008acd4e61
Summary: Moves internal usages of YGJustify to Justify. Differential Revision: https://internalfb.com/D49336538 fbshipit-source-id: b83b6f64cdefbcd0e184e029b17158a0a56b0d29
Summary: Moves internal usages of YGAlign to Align Changelog: [Internal] Differential Revision: https://internalfb.com/D49337511 fbshipit-source-id: dc334077ecaa0ccc21514d643cdbc0423fd1378c
Summary: X-link: facebook/react-native#39538 Pull Request resolved: facebook#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 4a83d7ffc21db577acf44f81da6ab10b37aaf0c8
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: deec3f83dc63483501b4619eaf0ec47f8568e8d0
|
This pull request was exported from Phabricator. Differential Revision: D49361677 |
NickGerleman
force-pushed
the
export-D49361677
branch
from
595b1f0
to
6aa62f0
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 19, 2023
Summary: X-link: facebook/react-native#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 526222d6cf9f3dc26eddfbfb8a04de4ba28e14a9
|
This pull request has been merged in 4ea6b4c. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 526222d6cf9f3dc26eddfbfb8a04de4ba28e14a9
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39538 X-link: facebook/yoga#1399 Moves internal usages of YGPositionType to PositionType bypass-github-export-checks Changelog: [Internal] Reviewed By: rshest Differential Revision: D49361677 fbshipit-source-id: 526222d6cf9f3dc26eddfbfb8a04de4ba28e14a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves internal usages of YGPositionType to PositionType
Changelog: [Internal]
Reviewed By: rshest
Differential Revision: D49361677