Tweak attribute whitelist table (#10559)

* Move null and undefined to the end * Highlight attributes with changes
facebook · Aug 28, 2017 · ebb5a33 · ebb5a33
1 parent 575cfad
commit ebb5a33
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/fixtures/attribute-behavior/src/App.js b/fixtures/attribute-behavior/src/App.js
@@ -21,14 +21,6 @@ const types = [
     testValue: 'a string',
     testDisplayValue: "'a string'",
   },
-  {
-    name: 'null',
-    testValue: null,
-  },
-  {
-    name: 'undefined',
-    testValue: undefined,
-  },
   {
     name: 'empty string',
     testValue: '',
@@ -115,6 +107,14 @@ const types = [
     name: 'function',
     testValue: function f() {},
   },
+  {
+    name: 'null',
+    testValue: null,
+  },
+  {
+    name: 'undefined',
+    testValue: undefined,
+  },
 ];
 
 function getProperty(propertyName) {
@@ -2841,7 +2841,14 @@ function CellContent(props) {
     if (rowIndex === 0) {
       return null;
     }
-    return <RowHeader>{attribute.name}</RowHeader>;
+    const hasSameBehaviorForAll = types.every(
+      type => table.get(attribute).get(type.name).hasSameBehavior
+    );
+    return (
+      <RowHeader>
+        {hasSameBehaviorForAll ? attribute.name : <b>{attribute.name}</b>}
+      </RowHeader>
+    );
   }
 
   if (rowIndex === 0) {