Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Image Element #2069

Closed
edmspjp opened this issue Aug 19, 2014 · 8 comments
Closed

SVG Image Element #2069

edmspjp opened this issue Aug 19, 2014 · 8 comments

Comments

@edmspjp
Copy link

edmspjp commented Aug 19, 2014

Can you please add support for SVG Image Element?
Thanks.

@sophiebits
Copy link
Collaborator

Merging into #1032.

@edmspjp
Copy link
Author

edmspjp commented Aug 20, 2014

Hi,

An issue closing means that it's already implemented, correct?

If yes, in which release it will be included?

Kind regards,

2014-08-19 23:19 GMT+01:00 Ben Alpert notifications@github.com:

Merging into #1032 #1032.


Reply to this email directly or view it on GitHub
#2069 (comment).

Paulo Jorge Dias
: à procura do erro certo
: looking for the right error

@sophiebits
Copy link
Collaborator

It's not implemented yet. #1032 is a issue for tracking any SVG tags or attributes that we're missing so I added your request there instead.

@edmspjp
Copy link
Author

edmspjp commented Aug 22, 2014

Ok, meanwhile I will use, for example (already tried and works):
<svg dangerouslySetInnerHTML={{__html: ""}} />
Is not a thing that I like, but because React is so amazing, when you implement the image sgv element it's just a matter of replacing this call in the component where it i used.
Kind regards.

@edmspjp
Copy link
Author

edmspjp commented Aug 22, 2014

Sorry it erases my solution because I used html tags.
The temporary solution will be:
<svg dangerouslySetInnerHTML={{__html: "<image x=" + this.props.x + " y=" + this.props.y + " width='200' height='200' fill='#90' stroke='#000' style='cursor:pointer' xlink:href=" + this.props.image + "/>"}} />
Kind regards.

@syranide
Copy link
Contributor

@edmspjp surround code with 1 or 3 ` and it will not be messed up.

@MrMatten
Copy link

Did this ever get fixed?

@epitaphmike
Copy link

@MrMatten You can use now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants