Additional SVG tag and attribute names #1032
Conversation
| text: false | ||
| text: false, | ||
| tspan: false | ||
|
|
|
Sorry for the delay! I just noticed that you had pushed new commits. Can you rebase though, we've already added dx and dy. We also need a change to the transform to make sure |
|
Like this? |
| @@ -155,6 +156,7 @@ var DefaultDOMPropertyConfig = { | |||
| stopColor: MUST_USE_ATTRIBUTE, | |||
| stopOpacity: MUST_USE_ATTRIBUTE, | |||
| stroke: MUST_USE_ATTRIBUTE, | |||
| strokeDasharray: MUST_USE_ATTRIBUTE, | |||
There was a problem hiding this comment.
You have a double space here.
|
Was red before due to bad rebase timing before.. caught a stray error off master. This is just rebased again and check out fine in Travis. |
|
This looks great, thanks a lot! I just split HTML and SVG properties into separate files so unfortunately you have a little bit of work to rebase there, sorry about that timing. But I made the internal diff, so as soon as you're ready, we should be good to go. |
The current set of SVG attributes / tag I felt like I needed them absolutely for my React/SVG editor app.
|
rebased it. |
|
Have you considered including the opacity attributes (#1171) as part of this pull request. |
Additional SVG tag and attribute names
|
Thanks! Sorry that took so long :/ |
The current set of SVG attributes / tag I felt like I needed
them absolutely for my React/SVG editor app.