-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "tracking" API to "tracing" #13641
Conversation
Details of bundled changes.Comparing: ecbf7af...69659e6 schedule
Generated by 🚫 dangerJS |
Oh hi @sizebot 👋 |
Gists have been updated as of the 16.5.2/0.5.0 release |
I hate to break the news but: #13683 |
😭 lol |
Well whenever we cut the next release, whoever cuts it, will need to make sure the blog post on reactjs.org is updated and just ping me about the gists 😄 |
@bvaughn does this break compatibility with React Native 0.57.0?
rolling back to 16.5.1 fixes this for me locally |
Hm, I would not expect it to because |
I see. My project is web + RN with a shared package.json and we usually keep up to date with react and don't stay on the exact one RN wants, this is usually ok but I guess this is a breaking change for us. tnx |
This is not supported and can always break indeed. |
* Replaced "tracking" with "tracing" in all directory and file names * Global rename of track/tracking/tracked to trace/tracing/traced
* Replaced "tracking" with "tracing" in all directory and file names * Global rename of track/tracking/tracked to trace/tracing/traced
I just encountered some issues here while upgrading from RN Everything worked except I was getting a horrific error message about the Be careful if you are upgrading from 0.56 to 0.57. If you get weirdness, simply follow the diffs here (https://github.com/react-native-community/rn-diff-purge) and look at all the After double-checking all the diffs between 0.56 up to and excluding 0.58, my project is building both Android and iOS successfully. |
Changes
Verification and testing
yarn test
andyarn test-build
tracing
andpackaging
fixtures against new built bundleFollow up work