Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo fix deps #13837

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Redo fix deps #13837

merged 3 commits into from
Sep 21, 2018

Conversation

chrisnojima
Copy link
Contributor

Last try broke hot server for some reason

  • hot-server works
  • storybook works
  • rn works

I tried to update to newest react but ran into an issue (posted: facebook/react#13641 (comment))

@keybase/react-hackers

@chrisnojima
Copy link
Contributor Author

@keybase/react-hackers bump

buoyad
buoyad approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@buoyad buoyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode failed -> rm -rf ~/.rncache fixed that

Android studio failed -> invalidating cache / force quit / writhing around fixed that

@chrisnojima chrisnojima merged commit 9ff5dd4 into master Sep 21, 2018
@chrisnojima chrisnojima deleted the nojima/DESKTOP-fix-deps-update branch January 3, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buoyad buoyad buoyad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisnojima @buoyad