Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds react-events package for internal testing #15150

Merged
merged 3 commits into from
Mar 19, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 19, 2019

This PR adds a react-events package that will act as the home for the user-facing APIs for the experimental event API. This package is only intended for internal testing right now. This also adds a bundle to the build script so we can build the react-events package to consume internally.

This PR will be a dependency for #15112.

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐾

@sizebot
Copy link

sizebot commented Mar 19, 2019

Details of bundled changes.

Comparing: d926936...2ac6750

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js n/a n/a 0 B 1.25 KB 0 B 662 B NODE_DEV
react-events.production.min.js n/a n/a 0 B 505 B 0 B 348 B NODE_PROD
ReactEvents-dev.js n/a n/a 0 B 1.22 KB 0 B 642 B FB_WWW_DEV
ReactEvents-prod.js n/a n/a 0 B 823 B 0 B 427 B FB_WWW_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 55cc921 into facebook:master Mar 19, 2019
@trueadm trueadm deleted the add-react-events-package branch March 19, 2019 15:12

// TODO: decide on the top-level export form.
// This is hacky but makes it work with both Rollup and Jest.
module.exports = ReactEvents.default || ReactEvents;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we've been doing this on our new packages. See: https://github.com/facebook/react/blob/master/packages/react-cache/index.js

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! #15152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants