-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal logic for listening to event responders #15168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits, but looks good to me. and I understood it this time!
Details of bundled changes.Comparing: c05b4b8...f9fa91b react-dom
Generated by 🚫 dangerJS |
This was referenced Mar 21, 2019
This was referenced Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is for an experimental event API that we're testing out internally at Facebook.
This PR adds logic to listen to events defined in event responders, following on from previous PRs:
This PR is quite difficult to test in isolation without creating unit tests that depend on internals (which I know we're moving away from as a team). In the next PR, I'll add further logic that connects the event firing to appropriate events that make for good public API tests. There isn't much to this PR to review other than a single function where most of the work happens, so hopefully it should be transparent as to what happens.l