Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build shallow renderer for FB #18153

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Don't build shallow renderer for FB #18153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/rollup/bundles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ const bundles = [
}),
},
{
bundleTypes: [FB_WWW_DEV, NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD],
bundleTypes: [NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't need any of these right? This is just building a forwarding file. We can just hard code that in the /npm/ folder instead. https://github.com/facebook/react/blob/master/packages/react-test-renderer/npm/shallow.js

Like we do for other forwarding modules that are just blank. https://github.com/facebook/react/blob/master/packages/react-dom/npm/server.js

Copy link
Contributor

@NMinhNguyen NMinhNguyen Feb 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something, but I think you'd still need UMD. But otherwise, for Node you should be able to hardcode in /npm/.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh. UMD. yea.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18157

moduleType: NON_FIBER_RENDERER,
entry: 'react-test-renderer/shallow',
global: 'ReactShallowRenderer',
Expand Down