Land effects refactor in main fork #20133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When detecting if a host tree was changed, we must check for deletions in addition to mounts and updates.
yarn replace-fork yarn lint --fix I also updated the eslint config to remove `subtreeTags` from list of disallowed fields in the old fork.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ed1b92:
|
Details of bundled changes.Comparing: 343d7a4...4ed1b92 react-dom
react-art
react-native-renderer
react-reconciler
react-test-renderer
Size changes (stable) |
Details of bundled changes.Comparing: 343d7a4...4ed1b92 react-dom
react-art
react-reconciler
react-test-renderer
react-native-renderer
Size changes (experimental) |
acdlite
force-pushed
the
land-effects-refactor
branch
3 times, most recently
from
99a5f22
to
4ed1b92
Compare
rickhanlonii
approved these changes
Oct 30, 2020
|
oh hi 4ed1b92 |
|
@gaearon I love cherry picking. So underrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn replace-fork
yarn lint --fix
I also updated the eslint config to remove
subtreeTagsfrom list of disallowed fields in the old fork.Will wait to land this until we confirm that the performance regression was fixed. Day 1 of results were good.