Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land effects refactor in main fork #20133

Closed
wants to merge 3 commits into from
Closed

Land effects refactor in main fork #20133

wants to merge 3 commits into from

Commits on Oct 29, 2020

  1. Check for deletions in hadNoMutationsEffects 

    When detecting if a host tree was changed, we must check for deletions
in addition to mounts and updates.
    @acdlite
    acdlite committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    ad8d4bc View commit details
    Browse the repository at this point in the history

  2. Land effects refactor in main fork 

    yarn replace-fork
yarn lint --fix

I also updated the eslint config to remove `subtreeTags` from list
of disallowed fields in the old fork.
    @acdlite
    acdlite committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    763d5f2 View commit details
    Browse the repository at this point in the history

  3. Remove dead branches

    @gaearon @acdlite
    gaearon authored and acdlite committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    4ed1b92 View commit details
    Browse the repository at this point in the history