New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant initial of isArray #21163

Merged

sebmarkbage merged 1 commit into facebook:master from behnammodi:sparated-is-array

Apr 1, 2021

Contributor

behnammodi commented Apr 1, 2021 •

edited

Loading

All test passed

@sebmarkbage @gaearon


          Remove redundant initial of isArray

4dbe7b6

facebook-github-bot added the CLA Signed label

Contributor Author

behnammodi commented Apr 1, 2021 •

edited

Loading

Also, I can separate these items:

Number.NaN                          [8 repeat]
Number.MAX_VALUE                    [2 repeat]
Number.POSITIVE_INFINITY            [2 repeat]
Number.NEGATIVE_INFINITY            [2 repeat]
Number.isNaN                        [7 repeat]

String.fromCharCode                 [4 repeat]

Array.from                          [75 repeat]

Object.defineProperty               [88 repeat]
Object.keys                         [65 repeat]
Object.assign                       [49 repeat]
Object.freeze                       [46 repeat]
Object.getOwnPropertyDescriptor     [32 repeat]
Object.create                       [17 repeat]
Object.entries                      [8 repeat]
Object.defineProperties             [5 repeat]
Object.preventExtensions            [6 repeat]
Object.seal                         [4 repeat]
Object.getOwnPropertySymbols        [3 repeat]
Object.getOwnPropertyNames          [3 repeat]
Object.getPrototypeOf               [3 repeat]

sebmarkbage merged commit b130a0f into facebook:master

Contributor Author

behnammodi commented Apr 1, 2021

@sebmarkbage Did you see my last comment?

Collaborator

sebmarkbage commented Apr 1, 2021

A lot of those are only used in DEV mode or tooling which are less size/perf sensitive so they matter less.

Contributor Author

behnammodi commented Apr 1, 2021

All of them?

Collaborator

sebmarkbage commented Apr 1, 2021 •

edited

Loading

I'm not sure why it looked like CI was passing on this PR but looks like Flow got broken because it can no longer figure out that isArray should use refinement. I had to revert it until we figure out how to carry this information over.

sebmarkbage added a commit that referenced this pull request


          Revert "Remove redundant initial of isArray (#21163)"

b4f119c

This reverts commit b130a0f.

Contributor Author

behnammodi commented Apr 7, 2021

@sebmarkbage Hi, do we have any updates about this issue?

sebmarkbage pushed a commit to sebmarkbage/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

f83791d

sebmarkbage mentioned this pull request

Reland Remove redundant initial of isArray #21188

Merged

sebmarkbage added a commit that referenced this pull request


          Reland Remove redundant initial of isArray (#21188)

172e89b

* Remove redundant initial of isArray (#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

Contributor Author

behnammodi commented Apr 7, 2021

@sebmarkbage Thanks and I think this PR needs to reland #21165

acdlite pushed a commit to acdlite/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

20d867e

acdlite pushed a commit to acdlite/react that referenced this pull request


          Revert "Remove redundant initial of isArray (facebook#21163)"

5557f7c

This reverts commit b130a0f.

acdlite pushed a commit to acdlite/react that referenced this pull request


          Reland Remove redundant initial of isArray (facebook#21188)

55e53bf

* Remove redundant initial of isArray (facebook#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

acdlite pushed a commit to acdlite/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

4f7d816

acdlite pushed a commit to acdlite/react that referenced this pull request


          Revert "Remove redundant initial of isArray (facebook#21163)"

99f5896

This reverts commit b130a0f.

acdlite pushed a commit to acdlite/react that referenced this pull request


          Reland Remove redundant initial of isArray (facebook#21188)

972ad95

* Remove redundant initial of isArray (facebook#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

acdlite pushed a commit to acdlite/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

047bb32

acdlite pushed a commit to acdlite/react that referenced this pull request


          Revert "Remove redundant initial of isArray (facebook#21163)"

eb1fef7

This reverts commit b130a0f.

acdlite pushed a commit to acdlite/react that referenced this pull request


          Reland Remove redundant initial of isArray (facebook#21188)

396f744

* Remove redundant initial of isArray (facebook#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

acdlite pushed a commit to acdlite/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

3a3bdb4

acdlite pushed a commit to acdlite/react that referenced this pull request


          Revert "Remove redundant initial of isArray (facebook#21163)"

58c42ed

This reverts commit b130a0f.

acdlite pushed a commit to acdlite/react that referenced this pull request


          Reland Remove redundant initial of isArray (facebook#21188)

02841e2

* Remove redundant initial of isArray (facebook#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

acdlite pushed a commit to acdlite/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

ee009d8

acdlite pushed a commit to acdlite/react that referenced this pull request


          Revert "Remove redundant initial of isArray (facebook#21163)"

40b8eab

This reverts commit b130a0f.

acdlite pushed a commit to acdlite/react that referenced this pull request


          Reland Remove redundant initial of isArray (facebook#21188)

5e7010d

* Remove redundant initial of isArray (facebook#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request


          React Native sync for revisions c9aab1c...f7cdc89

de318cd

Summary:
This sync includes the following changes:
- **[f7cdc8936](facebook/react@f7cdc8936 )**: Also turn off enableSyncDefaultUpdates in RN test renderer ([#21293](facebook/react#21293)) //<Ricky>//
- **[4c9eb2af1](facebook/react@4c9eb2af1 )**: Add dynamic flags to React Native ([#21291](facebook/react#21291)) //<Ricky>//
- **[9eddfbf5a](facebook/react@9eddfbf5a )**: [Fizz] Two More Fixes ([#21288](facebook/react#21288)) //<Sebastian Markbåge>//
- **[11b07597e](facebook/react@11b07597e )**: Fix classes ([#21283](facebook/react#21283)) //<Sebastian Markbåge>//
- **[96d00b9bb](facebook/react@96d00b9bb )**: [Fizz] Random Fixes ([#21277](facebook/react#21277)) //<Sebastian Markbåge>//
- **[81ef53953](facebook/react@81ef53953 )**: Always insert a dummy node with an ID into fallbacks ([#21272](facebook/react#21272)) //<Sebastian Markbåge>//
- **[a4a940d7a](facebook/react@a4a940d7a )**: [Fizz] Add unsupported Portal/Scope components ([#21261](facebook/react#21261)) //<Sebastian Markbåge>//
- **[f4d7a0f1e](facebook/react@f4d7a0f1e )**: Implement useOpaqueIdentifier ([#21260](facebook/react#21260)) //<Sebastian Markbåge>//
- **[dde875dfb](facebook/react@dde875dfb )**: [Fizz] Implement Hooks ([#21257](facebook/react#21257)) //<Sebastian Markbåge>//
- **[a597c2f5d](facebook/react@a597c2f5d )**: [Fizz] Fix reentrancy bug ([#21270](facebook/react#21270)) //<Sebastian Markbåge>//
- **[15e779d92](facebook/react@15e779d92 )**: Reconciler should inject its own version into DevTools hook ([#21268](facebook/react#21268)) //<Brian Vaughn>//
- **[4f76a28c9](facebook/react@4f76a28c9 )**: [Fizz] Implement New Context ([#21255](facebook/react#21255)) //<Sebastian Markbåge>//
- **[82ef450e0](facebook/react@82ef450e0 )**: remove obsolete SharedArrayBuffer ESLint config ([#21259](facebook/react#21259)) //<Henry Q. Dineen>//
- **[dbadfa2c3](facebook/react@dbadfa2c3 )**: [Fizz] Classes Follow Up ([#21253](facebook/react#21253)) //<Sebastian Markbåge>//
- **[686b635b7](facebook/react@686b635b7 )**: Prevent reading canonical property of null ([#21242](facebook/react#21242)) //<Joshua Gross>//
- **[bb88ce95a](facebook/react@bb88ce95a )**: Bugfix: Don't rely on `finishedLanes` for passive effects ([#21233](facebook/react#21233)) //<Andrew Clark>//
- **[343710c92](facebook/react@343710c92 )**: [Fizz] Fragments and Iterable support ([#21228](facebook/react#21228)) //<Sebastian Markbåge>//
- **[933880b45](facebook/react@933880b45 )**: Make time-slicing opt-in ([#21072](facebook/react#21072)) //<Ricky>//
- **[b0407b55f](facebook/react@b0407b55f )**: Support more empty types ([#21225](facebook/react#21225)) //<Sebastian Markbåge>//
- **[39713716a](facebook/react@39713716a )**: Merge isObject branches ([#21226](facebook/react#21226)) //<Sebastian Markbåge>//
- **[8a4a59c72](facebook/react@8a4a59c72 )**: Remove textarea special case from child fiber ([#21222](facebook/react#21222)) //<Sebastian Markbåge>//
- **[dc108b0f5](facebook/react@dc108b0f5 )**: Track which fibers scheduled the current render work ([#15658](facebook/react#15658)) //<Brian Vaughn>//
- **[6ea749170](facebook/react@6ea749170 )**: Fix typo in comment ([#21214](facebook/react#21214)) //<inokawa>//
- **[b38ac13f9](facebook/react@b38ac13f9 )**: DevTools: Add post-commit hook ([#21183](facebook/react#21183)) //<Brian Vaughn>//
- **[b943aeba8](facebook/react@b943aeba8 )**: Fix: Passive effect updates are never sync ([#21215](facebook/react#21215)) //<Andrew Clark>//
- **[d389c54d1](facebook/react@d389c54d1 )**: Offscreen: Use JS stack to track hidden/unhidden subtree state ([#21211](facebook/react#21211)) //<Brian Vaughn>//
- **[c486dc1a4](facebook/react@c486dc1a4 )**: Remove unnecessary processUpdateQueue ([#21199](facebook/react#21199)) //<Sebastian Markbåge>//
- **[cf45a623a](facebook/react@cf45a623a )**: [Fizz] Implement Classes ([#21200](facebook/react#21200)) //<Sebastian Markbåge>//
- **[75c616554](facebook/react@75c616554 )**: Include actual type of `Profiler#id` on type mismatch ([#20306](facebook/react#20306)) //<Sebastian Silbermann>//
- **[1214b302e](facebook/react@1214b302e )**: test: Fix "couldn't locate all inline snapshots" ([#21205](facebook/react#21205)) //<Sebastian Silbermann>//
- **[1a02d2792](facebook/react@1a02d2792 )**: style: delete unused isHost check ([#21203](facebook/react#21203)) //<wangao>//
- **[782f689ca](facebook/react@782f689ca )**: Don't double invoke getDerivedStateFromProps for module pattern ([#21193](facebook/react#21193)) //<Sebastian Markbåge>//
- **[e90c76a65](facebook/react@e90c76a65 )**: Revert "Offscreen: Use JS stack to track hidden/unhidden subtree state" ([#21194](facebook/react#21194)) //<Brian Vaughn>//
- **[1f8583de8](facebook/react@1f8583de8 )**: Offscreen: Use JS stack to track hidden/unhidden subtree state ([#21192](facebook/react#21192)) //<Brian Vaughn>//
- **[ad6e6ec7b](facebook/react@ad6e6ec7b )**: [Fizz] Prepare Recursive Loop for More Types ([#21186](facebook/react#21186)) //<Sebastian Markbåge>//
- **[172e89b4b](facebook/react@172e89b4b )**: Reland Remove redundant initial of isArray ([#21188](facebook/react#21188)) //<Sebastian Markbåge>//
- **[7c1ba2b57](facebook/react@7c1ba2b57 )**: Proposed new Suspense layout effect semantics ([#21079](facebook/react#21079)) //<Brian Vaughn>//
- **[316aa3686](facebook/react@316aa3686 )**: [Scheduler] Fix de-opt caused by out-of-bounds access ([#21147](facebook/react#21147)) //<Andrey Marchenko>//
- **[b4f119cdf](facebook/react@b4f119cdf )**: Revert "Remove redundant initial of isArray ([#21163](facebook/react#21163))" //<Sebastian Markbage>//
- **[c03197063](facebook/react@c03197063 )**: Revert "apply prettier ([#21165](facebook/react#21165))" //<Sebastian Markbage>//
- **[94fd1214d](facebook/react@94fd1214d )**: apply prettier ([#21165](facebook/react#21165)) //<Behnam Mohammadi>//
- **[b130a0f5c](facebook/react@b130a0f5c )**: Remove redundant initial of isArray ([#21163](facebook/react#21163)) //<Behnam Mohammadi>//
- **[2c9fef32d](facebook/react@2c9fef32d )**: Remove redundant initial of hasOwnProperty ([#21134](facebook/react#21134)) //<Behnam Mohammadi>//
- **[1cf9978d8](facebook/react@1cf9978d8 )**: Don't pass internals to callbacks ([#21161](facebook/react#21161)) //<Sebastian Markbåge>//
- **[b9e4c10e9](facebook/react@b9e4c10e9 )**: [Fizz] Implement all the DOM attributes and special cases ([#21153](facebook/react#21153)) //<Sebastian Markbåge>//
- **[f8ef4ff57](facebook/react@f8ef4ff57 )**: Flush discrete passive effects before paint ([#21150](facebook/react#21150)) //<Andrew Clark>//
- **[b48b38af6](facebook/react@b48b38af6 )**: Support nesting of startTransition and flushSync (alt) ([#21149](facebook/react#21149)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions c9aab1c...f7cdc89

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D27740113

fbshipit-source-id: 6e27204d78e3e16ed205170006cb97c0d6bfa957

koto pushed a commit to koto/react that referenced this pull request


          Remove redundant initial of isArray (facebook#21163)

b59dd2d

koto pushed a commit to koto/react that referenced this pull request


          Revert "Remove redundant initial of isArray (facebook#21163)"

2bc1324

This reverts commit b130a0f.

koto pushed a commit to koto/react that referenced this pull request


          Reland Remove redundant initial of isArray (facebook#21188)

f905680

* Remove redundant initial of isArray (facebook#21163)

* Reapply prettier

* Type the isArray function with refinement support

This ensures that an argument gets refined just like it does if isArray is
used directly.

I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.

* A few more

* Rename unit test to internal

This is not testing a bundle.

Co-authored-by: Behnam Mohammadi <itten@live.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels