[ServerRenderer] Add option to send instructions as data attributes #25437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
reviewed
Oct 7, 2022
| @@ -135,14 +168,15 @@ describe('ReactDOMFizzServer', () => { | |||
| while (fakeBody.firstChild) { | |||
| const node = fakeBody.firstChild; | |||
| if ( | |||
| node.nodeName === 'SCRIPT' && | |||
| (node.nodeName === 'SCRIPT' || node.nodeName === 'script') && | |||
There was a problem hiding this comment.
Why is the lower case needed? These always get uppercased by the DOM, right?
sebmarkbage
reviewed
Oct 7, 2022
| script.textContent = node.textContent; | ||
| fakeBody.removeChild(node); | ||
| parent.appendChild(script); | ||
| } else { | ||
| replaceScripts(node); |
There was a problem hiding this comment.
What's this doing? It looks like it's just doing the same thing as above but recursively?
We can kind of assume that the script tags are always inserted in the body since that what we do.
sebmarkbage
reviewed
Oct 7, 2022
| (CSPnonce === null || node.getAttribute('nonce') === CSPnonce) | ||
| ) { | ||
| const script = document.createElement('script'); | ||
| const script = document.createElement('SCRIPT'); |
There was a problem hiding this comment.
The branch here is really just assuming that these are inline scripts and to get them to execute, we need to reinsert them because (for security reasons innerHTML doesn't).
What you can do is check if .src is specified and if so, fake reading the source file as source, and then injecting it as a script tag with textContent instead. That would simulate more what the browser would do here.
sebmarkbage
reviewed
Oct 7, 2022
| window.__init_instruction_observer__ = () => { | ||
| global.testDocument = document; | ||
| global.MutationObserver = jsdom.window.MutationObserver; | ||
| reactInstructionObserver = ReactDOMFizzServer.getReactDOMClientMutationObserver(); |
There was a problem hiding this comment.
Like I mentioned below, we should simulate what would happen when we inject this as a <script src="..."> tag. Not getting an already initialized version of this file.
Once you add the new bundle you can read it with fs.readFileSync(require.resolve(script.src)).
sebmarkbage
reviewed
Oct 7, 2022
| writeChunk(destination, completeSegmentScript1Partial); | ||
| // <div data-attr='["$RS", " | ||
| (writerState: ScriptDataWriterState); | ||
| writeChunk(destination, dataElementStart); |
There was a problem hiding this comment.
Just noting for myself and others...
Originally I was hoping that we could attach these attributes to the node added by writeStartSegment. However, I don't think that would work.
<div hidden data-attr="...">
<div>first</div>
<div>second</div>
</div>
In this case the mutation observer would fire when the first div was added to the tree. Whether or not the second two divs have been streamed in yet. There's also no signal when it is done.
Therefore, unfortunately I think the best we can do is emit an extra node after - like this.
There was a problem hiding this comment.
For segments completing, I think we could maybe listen to any element being added to the segment and just move them as they come in. Since they're just getting added to something hidden anyway.
For boundaries completing, we'd still need a separate element regardless to know when it's safe to do the reveal.
Probably not worth the complexity to special case segments completing.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Oct 10, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see facebook#25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to maintain a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate file that is injected by the build system, similar to a macro. In the future, we could improve this further by running Closure on the instruction set instead of hardcoding the output. This isn't an urgent improvement, though, because we rarely modify the instruction set.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Oct 10, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see facebook#25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to maintain a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate file that is injected by the build system, similar to a macro. In the future, we could improve this further by running Closure on the instruction set instead of hardcoding the output. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com>
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Oct 14, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see facebook#25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to make this a bit more maintainable, and eventually have a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate files that are imported. In the future, we could improve this further by running Closure on the instruction set and generating it at build time. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com>
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Oct 14, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see facebook#25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to make this a bit more maintainable, and eventually have a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate files that are imported. In the future, we could improve this further by running Closure on the instruction set and generating it at build time. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com>
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Oct 14, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see facebook#25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to make this a bit more maintainable, and eventually have a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate files that are imported. In the future, we could improve this further by running Closure on the instruction set and generating it at build time. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com>
acdlite
added a commit
that referenced
this pull request
Oct 14, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see #25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to make this a bit more maintainable, and eventually have a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate files that are imported. In the future, we could improve this further by running Closure on the instruction set and generating it at build time. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com> Co-authored-by: Mofei Zhang <feifei0@fb.com>
mofeiZ
force-pushed
the
fizz-add-non-execution-format
branch
from
8002669 to
0881b4b
Compare
mofeiZ
commented
Oct 19, 2022
There was a problem hiding this comment.
Putting this up for review again (thanks @acdlite for helping me with the infra / bundling changes!)
Sorry this is such a large PR. I split out the renaming / trivial changes to the first commit, so ReactDOMFizzServer-test should be easier to review if you click past that.
Changes since last review:
- rebased on @acdlite 's changes (mostly renaming)
- data attribute format changed from JSON list to be unrolled strings
data-instr="$INSTR" data-arg0="param0" data-arg1="param1" ...- We ultimately still are calling JSON.parse for (1) unescaping added characters and (2) style resources, whose types are lists of strings
- Fix in ExternalRuntime: since this script may execute after some instruction tags have already arrived, we now process existing document elements
| @@ -25,11 +25,14 @@ let textCache; | |||
| let window; | |||
| let document; | |||
| let writable; | |||
| let CSPnonce = null; | |||
There was a problem hiding this comment.
Removed since it looks like we weren't really using this variable, but happy to add it back
|
|
||
| renderOptions = {}; | ||
| if (gate(flags => flags.enableFizzExternalRuntime)) { | ||
| renderOptions.bootstrapScriptContent = |
There was a problem hiding this comment.
This is pretty hacky
Since the external runtime is a standalone script (not a module), jest needs to do one of these.
- fork the source code (ReactDOMServerExternalRuntime.test.js)
- manually strip
import ... from ...and inject those imported declarations as globals
I chose (2) for now, but would love to change it if there is a cleaner alternative
| } else { | ||
| for (let i = 0; i < node.childNodes.length; i++) { | ||
| const inner = node.childNodes[i]; | ||
| replaceScriptsAndMove(inner, null); |
There was a problem hiding this comment.
From my understanding, we need this to be recursive since some tests stream into containers (divs inside of body). As a result, there are non top level scripts.
mofeiZ
force-pushed
the
fizz-add-non-execution-format
branch
2 times, most recently
from
2d1b1ce to
6facdf9
Compare
acdlite
reviewed
Oct 31, 2022
scripts/rollup/bundles.js
Outdated
| @@ -355,7 +355,7 @@ const bundles = [ | |||
|
|
|||
| /******* React DOM Fizz Server External Runtime *******/ | |||
| { | |||
| bundleTypes: [BROWSER_SCRIPT], | |||
| bundleTypes: [BROWSER_SCRIPT, FB_WWW_DEV, FB_WWW_PROD], | |||
There was a problem hiding this comment.
What's this for? We shouldn't need it
There was a problem hiding this comment.
I believe we need this because Comet infra will statically require this file in their bootstrap module + pass an empty string as externalRuntimeSrc (see internal diff + React sync). The external runtime then should be added into Meta's React build and synced into our repo.
There was a problem hiding this comment.
I see, I was thinking we would update the internal sync script to copy over the one used by npm. That's how we sync the ESLint plugin, for example. We're trying to trend in the direction of less FB-specific infra in the open source repo.
acdlite
reviewed
Oct 31, 2022
| } | ||
|
|
||
| /// Typechecking code, follows from above functions | ||
| function isSuspenseBoundaryID(s) { |
There was a problem hiding this comment.
I'm not convinced all these dev-only runtime type checking code is worth it. We don't even have a dev build of this module. The only time it runs is when we run our Jest tests.
There was a problem hiding this comment.
I was thinking we could enable this for dev mode internally, but happy to remove (I'm sure debugging $R instructions, should anything go wrong, probably falls on us too).
acdlite
reviewed
Oct 31, 2022
| switch (instr) { | ||
| case '$RX': | ||
| clientRenderBoundaryImpl( | ||
| node.getAttribute('data-rarg0'), |
There was a problem hiding this comment.
The way we access these in the other runtime is slightly different:
const dataset = node.data
dataset["rarg0"]See:
That would compress slightly better. But also we might as well be consistent.
Also, maybe these should use the $ prefix convention? And instead of rarg1 make it as short as possible to avoid clashes.
3-4 characters seems like enough, like $ra1, $ra2, etc.
There was a problem hiding this comment.
Thanks for pointing out dataset, will change my code to use that!
I had originally used $r. However, reading through the html spec for data attribute names (link), I think the name may need to be XML compatible. If this is the case, that would rule out $.
Happy to defer to you here though - I'm not at all familiar with specs + browser implementations
There was a problem hiding this comment.
Oh right. I remember now that useId generates ids with : for this reason. The convention for useId is :r1: so we can do something like that:
:a0, :a1 and so on.
In a follow up, what we should do is support the identifierPrefix option. Then prepend that to all of these attributes. We can send down prefix as an attribute early in the stream. So that the external runtime knows which attributes to look for. We wanted to do that anyway so that users don't have to manually pass the prefix to hydrateRoot.
acdlite
reviewed
Oct 31, 2022
| // This runtime may be sent to the client multiple times (if FizzServer.render | ||
| // is called more than once). Here, we check whether the mutation observer | ||
| // was already created / installed | ||
| if (!window.reactInstructionObserver && window.MutationObserver) { |
There was a problem hiding this comment.
We shouldn't need to check for the existence of MutationObserver. There's no fallback behavior so it should just hard error if it doesn't exist.
There was a problem hiding this comment.
Ah you're totally right, this can be moved to Meta's internal infra. Thanks for calling out the Meta-specific code in this PR
acdlite
reviewed
Oct 31, 2022
| // ReactDOMFizzInstructionSet | ||
| window.$RC = completeBoundary; | ||
| window.$RM = new Map(); | ||
| window.reactInstructionObserver = new MutationObserver(mutations => { |
There was a problem hiding this comment.
reactInstructionObserver needs to be obscure, too. It's essentially a private field; should only be accessed by this module. Use the $ naming convention.
mofeiZ
force-pushed
the
fizz-add-non-execution-format
branch
from
e0e1809 to
df858fe
Compare
|
@gnoff @sebmarkbage |
mofeiZ
commented
Nov 29, 2022
| const domBodyObserver = new MutationObserver(() => { | ||
| // We expect the body node to be stable once parsed / created | ||
| if (document.body) { | ||
| if (document.readyState === 'loading') { |
There was a problem hiding this comment.
Not sure the order of DOM parsing / changing readyState - this could totally be a redundant check
Added just in case readyState gets set loading -> interactive before mutation observer listeners are triggered.
(experimented with inline scripts on my laptop's version of Chrome, but wary about other browser implementations)
There was a problem hiding this comment.
I don't know off the top of my head. seems safe enough to leave in
gnoff
requested changes
Nov 30, 2022
| } else { | ||
| // body may not exist yet if the fizz runtime is sent in <head> | ||
| // (e.g. as a preinit resource) | ||
| const domBodyObserver = new MutationObserver(() => { |
There was a problem hiding this comment.
I feel like I am missing something but does this observer ever observe anything?
There was a problem hiding this comment.
Ahh I can't believe I didn't call observe, thanks so much for catching this - definitely a problem.
| const domBodyObserver = new MutationObserver(() => { | ||
| // We expect the body node to be stable once parsed / created | ||
| if (document.body) { | ||
| if (document.readyState === 'loading') { |
There was a problem hiding this comment.
I don't know off the top of my head. seems safe enough to leave in
|
(Sorry for the back and forth, and thanks again for the review! Once again putting this back on your queue @gnoff ) |
1 similar comment
|
(Sorry for the back and forth, and thanks again for the review! Once again putting this back on your queue @gnoff ) |
gnoff
approved these changes
Nov 30, 2022
sebmarkbage
reviewed
Nov 30, 2022
| @@ -120,4 +140,59 @@ function mergeOptions(options: Object, defaultOptions: Object): Object { | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
This function doesn't really need to exist. The function name is longer than the syntax to write this out. This is strictly worse since it made me look up this definition, thinking it was something more involved, but it also drops the types because it's effectively "any" typed.
sebmarkbage
reviewed
Nov 30, 2022
| } | ||
| return nodes.filter( | ||
| n => | ||
| (n.tagName !== 'SCRIPT' && n.tagName !== 'script') || |
There was a problem hiding this comment.
Why the lower case? SVG?
There was a problem hiding this comment.
@sebmarkbage
I'm not sure why this is needed, but I see that tagName is sometimes lowercase. I saw some existing code like this, and didn't think too much of it.
Can look into it if it seems suggestive of a larger issue!
mofeiZ
added a commit
to mofeiZ/react
that referenced
this pull request
Dec 2, 2022
…acebook#25437) ### Changes made: - Running with enableFizzExternalRuntime (feature flag) and unstable_externalRuntimeSrc (param) will generate html nodes with data attributes that encode Fizz instructions. ``` <div hidden data-rxi="" data-bid="param0" data-dgst="param1" ></div> ``` - Added an external runtime browser script `ReactDOMServerExternalRuntime`, which processes and removes these nodes - This runtime should be passed as to renderInto[...] via `unstable_externalRuntimeSrc` - Since this runtime is render blocking (for all streamed suspense boundaries and segments), we want this to reach the client as early as possible. By default, Fizz will send this script at the end of the shell when it detects dynamic content (e.g. suspenseful pending tasks), but it can be sent even earlier by calling `preinit(...)` inside a component. - The current implementation relies on Float to dedupe sending `unstable_externalRuntimeSrc`, so `enableFizzExternalRuntime` is only valid when `enableFloat` is also set.
rickhanlonii
pushed a commit
that referenced
this pull request
Dec 3, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see #25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to make this a bit more maintainable, and eventually have a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate files that are imported. In the future, we could improve this further by running Closure on the instruction set and generating it at build time. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com> Co-authored-by: Mofei Zhang <feifei0@fb.com>
rickhanlonii
pushed a commit
that referenced
this pull request
Dec 3, 2022
…om-bindings (#25617) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> Following [comment](#25437 (comment)) in #25437 , the external runtime implementation should be moved from `react-dom` to `react-dom-bindings`. I did have a question here: I set the entrypoint to `react-dom/unstable_server-external-runtime.js`, since a.) I was following #25436 as an example and b.) `react-dom-bindings` was missing a `README.md` and `npm/`. This also involved adding the external runtime to `package.json`. However, the external runtime isn't really a `react-dom` entrypoint. Is this change alright, or should I change the bundling code instead? ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
mofeiZ
added a commit
to mofeiZ/react
that referenced
this pull request
Dec 5, 2022
We're adding an option to Fizz to support an alternate output format that doesn't rely on inline script tags (see facebook#25437). The two outputs will share the same "instruction set" of functions. These functions are currently inlined into the source file; to make this a bit more maintainable, and eventually have a single source of truth, in preparation for the new option, this commit moves the instruction set to a separate files that are imported. In the future, we could improve this further by running Closure on the instruction set and generating it at build time. This isn't an urgent improvement, though, because we rarely modify the instruction set. Co-authored-by: Mofei Zhang <feifei0@fb.com> Co-authored-by: Mofei Zhang <feifei0@fb.com>
mofeiZ
added a commit
to mofeiZ/react
that referenced
this pull request
Dec 5, 2022
…om-bindings (facebook#25617) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> Following [comment](facebook#25437 (comment)) in facebook#25437 , the external runtime implementation should be moved from `react-dom` to `react-dom-bindings`. I did have a question here: I set the entrypoint to `react-dom/unstable_server-external-runtime.js`, since a.) I was following facebook#25436 as an example and b.) `react-dom-bindings` was missing a `README.md` and `npm/`. This also involved adding the external runtime to `package.json`. However, the external runtime isn't really a `react-dom` entrypoint. Is this change alright, or should I change the bundling code instead? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
mofeiZ
added a commit
to mofeiZ/react
that referenced
this pull request
Dec 5, 2022
…acebook#25437) ### Changes made: - Running with enableFizzExternalRuntime (feature flag) and unstable_externalRuntimeSrc (param) will generate html nodes with data attributes that encode Fizz instructions. ``` <div hidden data-rxi="" data-bid="param0" data-dgst="param1" ></div> ``` - Added an external runtime browser script `ReactDOMServerExternalRuntime`, which processes and removes these nodes - This runtime should be passed as to renderInto[...] via `unstable_externalRuntimeSrc` - Since this runtime is render blocking (for all streamed suspense boundaries and segments), we want this to reach the client as early as possible. By default, Fizz will send this script at the end of the shell when it detects dynamic content (e.g. suspenseful pending tasks), but it can be sent even earlier by calling `preinit(...)` inside a component. - The current implementation relies on Float to dedupe sending `unstable_externalRuntimeSrc`, so `enableFizzExternalRuntime` is only valid when `enableFloat` is also set.
mofeiZ
added a commit
to mofeiZ/react
that referenced
this pull request
Dec 9, 2022
mofeiZ
added a commit
that referenced
this pull request
Jan 6, 2023
…me (#25862) ~~[Fizz] Duplicate completeBoundaryWithStyles to not reference globals~~ ## Summary Follow-up / cleanup PR to #25437 - `completeBoundaryWithStylesInlineLocals` is used by the Fizz external runtime, which bundles together all Fizz instruction functions (and is able to reference / rename `completeBoundary` and `resourceMap` as locals). - `completeBoundaryWithStylesInlineGlobals` is used by the Fizz inline script writer, which sends Fizz instruction functions on an as-needed basis. This version needs to reference `completeBoundary($RC)` and `resourceMap($RM)` as globals. Ideally, Closure would take care of inlining a shared implementation, but I couldn't figure out a zero-overhead inline due to lack of an `@inline` compiler directive. It seems that Closure thinks that a shared `completeBoundaryWithStyles` is too large and will always keep it as a separate function. I've also tried currying / writing a higher order function (`getCompleteBoundaryWithStyles`) with no luck ## How did you test this change? - generated Fizz inline instructions should be unchanged - bundle size for unstable_external_runtime should be slightly smaller (due to lack of globals) - `ReactDOMFizzServer-test.js` and `ReactDOMFloat-test.js` should be unaffected
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
…me (#25862) ~~[Fizz] Duplicate completeBoundaryWithStyles to not reference globals~~ ## Summary Follow-up / cleanup PR to #25437 - `completeBoundaryWithStylesInlineLocals` is used by the Fizz external runtime, which bundles together all Fizz instruction functions (and is able to reference / rename `completeBoundary` and `resourceMap` as locals). - `completeBoundaryWithStylesInlineGlobals` is used by the Fizz inline script writer, which sends Fizz instruction functions on an as-needed basis. This version needs to reference `completeBoundary($RC)` and `resourceMap($RM)` as globals. Ideally, Closure would take care of inlining a shared implementation, but I couldn't figure out a zero-overhead inline due to lack of an `@inline` compiler directive. It seems that Closure thinks that a shared `completeBoundaryWithStyles` is too large and will always keep it as a separate function. I've also tried currying / writing a higher order function (`getCompleteBoundaryWithStyles`) with no luck ## How did you test this change? - generated Fizz inline instructions should be unchanged - bundle size for unstable_external_runtime should be slightly smaller (due to lack of globals) - `ReactDOMFizzServer-test.js` and `ReactDOMFloat-test.js` should be unaffected DiffTrain build for [0b97441](0b97441) [View git log for this commit](https://github.com/facebook/react/commits/0b974418c9a56f6c560298560265dcf4b65784bc)
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 30, 2023
Summary: Three problems popped up during the sync: - facebook/react@07f46ecf2 breaks breaks tests - facebook/react@6fb8133ed breaks fbsource tests. I added a workaround and created a test for the team that owns the test. - https://fb.workplace.com/groups/flowlang/permalink/1198137807458547/ enables local type interference in fbsource but not in github React repo and some code breaks. Addressed in facebook/react#26064 This sync includes the following changes: - **[17f6912a4](facebook/react@17f6912a4 )**: Add flow types to ReactFiberHooks ([#25752](facebook/react#25752)) //<Samuel Susla>// - **[f101c2d0d](facebook/react@f101c2d0d )**: Remove Reconciler fork (2/2) ([#25775](facebook/react#25775)) //<Jan Kassens>// - **[420f0b7fa](facebook/react@420f0b7fa )**: Remove Reconciler fork (1/2) ([#25774](facebook/react#25774)) //<Jan Kassens>// - **[3ba7add60](facebook/react@3ba7add60 )**: Allow async blocks in `to(Error|Warn)Dev` ([#25338](facebook/react#25338)) //<Sebastian Silbermann>// - **[fa11bd6ec](facebook/react@fa11bd6ec )**: [ServerRenderer] Add option to send instructions as data attributes ([#25437](facebook/react#25437)) //<mofeiZ>// - **[e98225485](facebook/react@e98225485 )**: Add ref cleanup function ([#25686](facebook/react#25686)) //<Samuel Susla>// - **[15557fa67](facebook/react@15557fa67 )**: [Fix] properly track `useId` use in StrictMode in development ([#25713](facebook/react#25713)) //<Josh Story>// - **[8a23def32](facebook/react@8a23def32 )**: Resubmit Add HydrationSyncLane ([#25711](facebook/react#25711)) //<Tianyu Yao>// - **[2655c9354](facebook/react@2655c9354 )**: Fizz Browser: fix precomputed chunk being cleared on Node 18 ([#25645](facebook/react#25645)) //<Jimmy Lai>// - **[c08d8b804](facebook/react@c08d8b804 )**: Revert "Add SyncHydrationLane" ([#25708](facebook/react#25708)) //<Tianyu Yao>// - **[56ffca8b9](facebook/react@56ffca8b9 )**: Add Bun streaming server renderer ([#25597](facebook/react#25597)) //<Colin McDonnell>// - **[f31005d6a](facebook/react@f31005d6a )**: Add SyncHydrationLane ([#25698](facebook/react#25698)) //<Tianyu Yao>// - **[f284d9faf](facebook/react@f284d9faf )**: Track ThenableState alongside other hooks //<Andrew Clark>// - **[6b4c0314e](facebook/react@6b4c0314e )**: Check thenable instead of thenableState //<Andrew Clark>// - **[33e3d2878](facebook/react@33e3d2878 )**: Reuse hooks when replaying a suspended component //<Andrew Clark>// - **[4387d752d](facebook/react@4387d752d )**: Allow more hooks to be added when replaying mount //<Andrew Clark>// - **[5eb78d0a0](facebook/react@5eb78d0a0 )**: Pass ThenableState to replaySuspendedUnitOfWork //<Andrew Clark>// - **[4a2d86bdd](facebook/react@4a2d86bdd )**: Don't reset work loop until stack is unwound //<Andrew Clark>// - **[9dfbd9fa9](facebook/react@9dfbd9fa9 )**: use: Don't suspend if there are pending updates //<Andrew Clark>// - **[44c4e6f4d](facebook/react@44c4e6f4d )**: Force unwind work loop during selective hydration ([#25695](facebook/react#25695)) //<Andrew Clark>// - **[7b17f7bbf](facebook/react@7b17f7bbf )**: Enable warning for defaultProps on function components for everyone ([#25699](facebook/react#25699)) //<Sebastian Markbåge>// - **[6fb8133ed](facebook/react@6fb8133ed )**: Turn on string ref deprecation warning for everybody (not codemoddable) ([#25383](facebook/react#25383)) //<Sebastian Silbermann>// - **[07f46ecf2](facebook/react@07f46ecf2 )**: Turn on key spread warning in jsx-runtime for everyone ([#25697](facebook/react#25697)) //<Sebastian Markbåge>// - **[d65b88d03](facebook/react@d65b88d03 )**: Eagerly initialize an mutable object for instance.refs ([#25696](facebook/react#25696)) //<Sebastian Markbåge>// - **[c343f8025](facebook/react@c343f8025 )**: [react-float] feature detect getRootNode ([#25689](facebook/react#25689)) //<Jan Kassens>// - **[e1dd0a2f5](facebook/react@e1dd0a2f5 )**: Remove recoverable error when a sync update flows into a dehydrated boundary ([#25692](facebook/react#25692)) //<Sebastian Markbåge>// - **[c54e3541b](facebook/react@c54e3541b )**: [DevTools] bug fix for Hydrating fibers ([#25663](facebook/react#25663)) //<Mengdi Chen>// Changelog: [General][Changed] - React Native sync for revisions d1e35c7...17f6912 jest_e2e[run_all_tests] Reviewed By: makovkastar Differential Revision: D42804802 fbshipit-source-id: 6a9f00724cc73378025bbd04edb2d17760a87280
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Three problems popped up during the sync: - facebook/react@07f46ecf2 breaks breaks tests - facebook/react@6fb8133ed breaks fbsource tests. I added a workaround and created a test for the team that owns the test. - https://fb.workplace.com/groups/flowlang/permalink/1198137807458547/ enables local type interference in fbsource but not in github React repo and some code breaks. Addressed in facebook/react#26064 This sync includes the following changes: - **[17f6912a4](facebook/react@17f6912a4 )**: Add flow types to ReactFiberHooks ([facebook#25752](facebook/react#25752)) //<Samuel Susla>// - **[f101c2d0d](facebook/react@f101c2d0d )**: Remove Reconciler fork (2/2) ([facebook#25775](facebook/react#25775)) //<Jan Kassens>// - **[420f0b7fa](facebook/react@420f0b7fa )**: Remove Reconciler fork (1/2) ([facebook#25774](facebook/react#25774)) //<Jan Kassens>// - **[3ba7add60](facebook/react@3ba7add60 )**: Allow async blocks in `to(Error|Warn)Dev` ([facebook#25338](facebook/react#25338)) //<Sebastian Silbermann>// - **[fa11bd6ec](facebook/react@fa11bd6ec )**: [ServerRenderer] Add option to send instructions as data attributes ([facebook#25437](facebook/react#25437)) //<mofeiZ>// - **[e98225485](facebook/react@e98225485 )**: Add ref cleanup function ([facebook#25686](facebook/react#25686)) //<Samuel Susla>// - **[15557fa67](facebook/react@15557fa67 )**: [Fix] properly track `useId` use in StrictMode in development ([facebook#25713](facebook/react#25713)) //<Josh Story>// - **[8a23def32](facebook/react@8a23def32 )**: Resubmit Add HydrationSyncLane ([facebook#25711](facebook/react#25711)) //<Tianyu Yao>// - **[2655c9354](facebook/react@2655c9354 )**: Fizz Browser: fix precomputed chunk being cleared on Node 18 ([facebook#25645](facebook/react#25645)) //<Jimmy Lai>// - **[c08d8b804](facebook/react@c08d8b804 )**: Revert "Add SyncHydrationLane" ([facebook#25708](facebook/react#25708)) //<Tianyu Yao>// - **[56ffca8b9](facebook/react@56ffca8b9 )**: Add Bun streaming server renderer ([facebook#25597](facebook/react#25597)) //<Colin McDonnell>// - **[f31005d6a](facebook/react@f31005d6a )**: Add SyncHydrationLane ([facebook#25698](facebook/react#25698)) //<Tianyu Yao>// - **[f284d9faf](facebook/react@f284d9faf )**: Track ThenableState alongside other hooks //<Andrew Clark>// - **[6b4c0314e](facebook/react@6b4c0314e )**: Check thenable instead of thenableState //<Andrew Clark>// - **[33e3d2878](facebook/react@33e3d2878 )**: Reuse hooks when replaying a suspended component //<Andrew Clark>// - **[4387d752d](facebook/react@4387d752d )**: Allow more hooks to be added when replaying mount //<Andrew Clark>// - **[5eb78d0a0](facebook/react@5eb78d0a0 )**: Pass ThenableState to replaySuspendedUnitOfWork //<Andrew Clark>// - **[4a2d86bdd](facebook/react@4a2d86bdd )**: Don't reset work loop until stack is unwound //<Andrew Clark>// - **[9dfbd9fa9](facebook/react@9dfbd9fa9 )**: use: Don't suspend if there are pending updates //<Andrew Clark>// - **[44c4e6f4d](facebook/react@44c4e6f4d )**: Force unwind work loop during selective hydration ([facebook#25695](facebook/react#25695)) //<Andrew Clark>// - **[7b17f7bbf](facebook/react@7b17f7bbf )**: Enable warning for defaultProps on function components for everyone ([facebook#25699](facebook/react#25699)) //<Sebastian Markbåge>// - **[6fb8133ed](facebook/react@6fb8133ed )**: Turn on string ref deprecation warning for everybody (not codemoddable) ([facebook#25383](facebook/react#25383)) //<Sebastian Silbermann>// - **[07f46ecf2](facebook/react@07f46ecf2 )**: Turn on key spread warning in jsx-runtime for everyone ([facebook#25697](facebook/react#25697)) //<Sebastian Markbåge>// - **[d65b88d03](facebook/react@d65b88d03 )**: Eagerly initialize an mutable object for instance.refs ([facebook#25696](facebook/react#25696)) //<Sebastian Markbåge>// - **[c343f8025](facebook/react@c343f8025 )**: [react-float] feature detect getRootNode ([facebook#25689](facebook/react#25689)) //<Jan Kassens>// - **[e1dd0a2f5](facebook/react@e1dd0a2f5 )**: Remove recoverable error when a sync update flows into a dehydrated boundary ([facebook#25692](facebook/react#25692)) //<Sebastian Markbåge>// - **[c54e3541b](facebook/react@c54e3541b )**: [DevTools] bug fix for Hydrating fibers ([facebook#25663](facebook/react#25663)) //<Mengdi Chen>// Changelog: [General][Changed] - React Native sync for revisions d1e35c7...17f6912 jest_e2e[run_all_tests] Reviewed By: makovkastar Differential Revision: D42804802 fbshipit-source-id: 6a9f00724cc73378025bbd04edb2d17760a87280
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
…om-bindings (#25617) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> Following [comment](facebook/react#25437 (comment)) in #25437 , the external runtime implementation should be moved from `react-dom` to `react-dom-bindings`. I did have a question here: I set the entrypoint to `react-dom/unstable_server-external-runtime.js`, since a.) I was following #25436 as an example and b.) `react-dom-bindings` was missing a `README.md` and `npm/`. This also involved adding the external runtime to `package.json`. However, the external runtime isn't really a `react-dom` entrypoint. Is this change alright, or should I change the bundling code instead? ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
ReactDOMServerExternalRuntime, which processes and removes these nodesunstable_externalRuntimeSrcpreinit(...)inside a component.unstable_externalRuntimeSrc, soenableFizzExternalRuntimeis only valid whenenableFloatis also set.What's left (done)
AddenableFizzExternalRuntimeas an entrypoint parameterAdd a MutationObserver implementationAdd ^ to test setup (when using Meta's feature flags)Summary
How did you test this change?