[Fizz] Readability refactor (follow up to #25437) #25865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: b14d7fa...d19472b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
@gnoff ping for feedback 🙂 |
gnoff
reviewed
Jan 6, 2023
There was a problem hiding this comment.
I'm not convinced each variant needs to be broken out into separate functions but I already felt the pain of the previous factoring when implementing renderIntoContainer and did a very similar reorganization of the writeCompletedBoundary implementation.
Because rebasing that PR onto this may be riskier than the other way around do you mind waiting until that one merges in and then rebasing onto it?
Leebonggu
reviewed
Apr 27, 2023
Comment on lines
+2424
to
+2440
| if ( | ||
| !enableFizzExternalRuntime || | ||
| responseState.streamingFormat === ScriptStreamingFormat; | ||
| if (scriptFormat) { | ||
| writeChunk(destination, responseState.startInlineScript); | ||
| if (!responseState.sentCompleteSegmentFunction) { | ||
| // The first time we write this, we'll need to include the full implementation. | ||
| responseState.sentCompleteSegmentFunction = true; | ||
| writeChunk(destination, completeSegmentScript1Full); | ||
| } else { | ||
| // Future calls can just reuse the same function. | ||
| writeChunk(destination, completeSegmentScript1Partial); | ||
| } | ||
| responseState.streamingFormat === ScriptStreamingFormat | ||
| ) { | ||
| return writeCompletedSegmentInstructionScript( | ||
| destination, | ||
| responseState, | ||
| contentSegmentID, | ||
| ); | ||
| } else { | ||
| return writeCompletedSegmentInstructionData( | ||
| destination, | ||
| responseState, | ||
| contentSegmentID, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
hello @mofeiZ
how about this?
I think else seems unnecessary 😄
if (
!enableFizzExternalRuntime ||
responseState.streamingFormat === ScriptStreamingFormat
) {
return writeCompletedSegmentInstructionScript(
destination,
responseState,
contentSegmentID,
);
}
return writeCompletedSegmentInstructionData(
destination,
responseState,
contentSegmentID,
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up / cleanup PR to #25437
write[...]Instructioninto two sets of functions, functions writing the inline script format and functions writing the data attribute format. This is only moving code around (no functional changes)How did you test this change?
ReactDOMFizzServer-test.jsReactDOMFloat-test.js