Upgrade prettier

[kassens]

The old version of prettier we were using didn't support the Flow syntax to access properties in a type using SomeType['prop']. This updates prettier and rollup-plugin-prettier to the latest versions.

I added the prettier config arrowParens: "avoid" to reduce the diff size as the default has changed in Prettier 2.0. The largest amount of changes comes from function expressions now having a space. This doesn't have an option to preserve the old behavior, so we have to update this.

[kassens]

Note, I kept the formatting changes in a different commit from manual changes to help review.

[kassens]

prettier didn't like the top level return. Used process.exit(0) instead to replicate the behavior (see line 82 is also using process.exit already).

[gnoff]

The config changes make sense. the code changes that I checked seem to make sense. What is the expected code review treatment for tool-updated code? I can go line by line but don't want to if not necessary cc @sebmarkbage

[kassens]

@gnoff I do a combination of:

• review manual changes (that's why I separated them into separate git commits)
• spot check automated changes that there's no unintended side effects

[kassens]

This used a "type comment" before of the form:

/*::
[flow only code here]
*/

The flow prettier parser parses this as a pure AST w/o the comment and then when it's printed the comment is removed. Most of the scripts don't use types, I think we don't loose much by removing this here.

[gnoff]

should this be 'hermes' or 'flow'?

[kassens]

The hermes PR wasn't merged yet due to concerns of size IIRC. Looks like flow is current enough for the moment to parser everything. (not actually sure what the plan is going forward with hermes vs. flow parser).

[gnoff]

Ah I see

[react-sizebot]

Comparing: 1f5ce59...4da1450

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	154.83 kB	154.83 kB	=	49.11 kB	49.11 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	156.83 kB	156.83 kB	=	49.77 kB	49.77 kB
facebook-www/ReactDOM-prod.classic.js	+0.12%	533.17 kB	533.79 kB	+0.10%	94.97 kB	95.06 kB
facebook-www/ReactDOM-prod.modern.js	+0.10%	518.27 kB	518.81 kB	+0.11%	92.73 kB	92.83 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
facebook-www/SchedulerPostTask-prod.classic.js	+0.54%	4.07 kB	4.10 kB	+0.53%	1.12 kB	1.13 kB
facebook-www/SchedulerPostTask-prod.modern.js	+0.54%	4.07 kB	4.10 kB	+0.53%	1.12 kB	1.13 kB
facebook-www/SchedulerPostTask-profiling.classic.js	+0.54%	4.07 kB	4.10 kB	+0.53%	1.12 kB	1.13 kB
facebook-www/SchedulerPostTask-profiling.modern.js	+0.54%	4.07 kB	4.10 kB	+0.53%	1.12 kB	1.13 kB
facebook-react-native/react/cjs/React-prod.js	+0.38%	20.75 kB	20.83 kB	+0.12%	5.18 kB	5.18 kB
facebook-www/React-prod.modern.js	+0.37%	21.08 kB	21.16 kB	+0.06%	5.28 kB	5.28 kB
facebook-react-native/react/cjs/React-profiling.js	+0.37%	21.36 kB	21.44 kB	+0.13%	5.30 kB	5.31 kB
facebook-www/React-prod.classic.js	+0.36%	21.37 kB	21.44 kB	+0.09%	5.35 kB	5.36 kB
facebook-www/React-profiling.modern.js	+0.36%	21.69 kB	21.76 kB	+0.07%	5.40 kB	5.41 kB
facebook-www/React-profiling.classic.js	+0.35%	21.97 kB	22.05 kB	+0.09%	5.48 kB	5.49 kB
oss-experimental/react-dom/client.js	+0.32%	0.62 kB	0.62 kB	+0.35%	0.29 kB	0.29 kB
oss-stable-semver/react-dom/client.js	+0.32%	0.62 kB	0.62 kB	+0.35%	0.29 kB	0.29 kB
oss-stable/react-dom/client.js	+0.32%	0.62 kB	0.62 kB	+0.35%	0.29 kB	0.29 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js	+0.31%	4.78 kB	4.80 kB	=	1.15 kB	1.15 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js	+0.31%	4.78 kB	4.80 kB	=	1.15 kB	1.15 kB
facebook-www/ReactIs-prod.classic.js	+0.28%	5.35 kB	5.36 kB	+0.08%	1.30 kB	1.31 kB
facebook-www/ReactIs-prod.modern.js	+0.28%	5.35 kB	5.36 kB	+0.08%	1.30 kB	1.31 kB
facebook-react-native/scheduler/cjs/SchedulerMock-prod.js	+0.25%	12.28 kB	12.31 kB	+0.10%	2.88 kB	2.88 kB
facebook-react-native/scheduler/cjs/Scheduler-prod.js	+0.25%	10.46 kB	10.49 kB	+0.15%	2.64 kB	2.64 kB
facebook-www/SchedulerMock-prod.classic.js	+0.24%	12.56 kB	12.59 kB	+0.07%	2.97 kB	2.97 kB
facebook-www/SchedulerMock-prod.modern.js	+0.24%	12.56 kB	12.59 kB	+0.07%	2.97 kB	2.97 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js	+0.23%	11.07 kB	11.09 kB	+0.07%	2.78 kB	2.78 kB
facebook-www/Scheduler-prod.classic.js	+0.22%	11.77 kB	11.80 kB	+0.14%	2.92 kB	2.92 kB
facebook-www/Scheduler-prod.modern.js	+0.22%	11.77 kB	11.80 kB	+0.14%	2.92 kB	2.92 kB

Generated by 🚫 dangerJS against 4da1450

[gnoff]

@kassens When I try to annotate the type of this for functions the flow parser chokes but the babel parser still works

function myFunc (this: Thing) {}

let thing: Thing = {};
myFunc.call(thing);

This flow syntax is a little new to me, not sure when they introduced it but seems necessary without suppressing warnings and it's nice to have some type safety for the this argument. Is there a reason flow is better than babel for the prettier parser?

Also, I tried something like this with both flow and babel parsers and neither supported it

type X<T: ['one', 'two']> = {
  one: T[0],
  two: T[1]
}

Maybe this is still blocked on the hermes-flow parser patch?