Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Float] support fetchpriority on ReactDOM.preload() and ReactDOM.preinit() #26880

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[Float] support fetchpriority on ReactDOM.preload() and ReactDOM.preinit() #26880

merged 1 commit into from
Jun 1, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented May 31, 2023 •
edited
Loading

exposes fetchPriority as an option for ReactDOM.preload() and ReactDOM.preinit()

the typings should be 'high' | 'low' | 'auto'

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 31, 2023
@react-sizebot
Copy link

react-sizebot commented May 31, 2023 •
edited
Loading

Comparing: ae31d2e...67441f9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.05% 164.28 kB 164.37 kB +0.02% 51.79 kB 51.80 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.05% 171.72 kB 171.81 kB +0.02% 54.02 kB 54.03 kB
facebook-www/ReactDOM-prod.classic.js +0.03% 570.52 kB 570.67 kB +0.01% 100.66 kB 100.68 kB
facebook-www/ReactDOM-prod.modern.js +0.03% 554.26 kB 554.41 kB +0.01% 97.84 kB 97.85 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 67441f9

@gnoff gnoff force-pushed the float-fetchpriority branch 3 times, most recently from e5c2ed4 to 0cbcc01 Compare May 31, 2023 22:03
@gnoff gnoff changed the title Float fetchpriority [Float] support fetchpriority on ReactDOM.preload() and ReactDOM.preinit() May 31, 2023
@gnoff gnoff force-pushed the float-fetchpriority branch from 0cbcc01 to 5a690dc Compare May 31, 2023 22:18
@gnoff gnoff force-pushed the float-fetchpriority branch from 5a690dc to 67441f9 Compare May 31, 2023 23:54
@gnoff
Copy link
Collaborator Author

gnoff commented Jun 1, 2023

cc @eps1lon TS type should be updated. Do you mind updating? If you can't I'll try to PR

@gnoff gnoff merged commit 042d8f6 into facebook:main Jun 1, 2023
@gnoff gnoff deleted the float-fetchpriority branch June 1, 2023 20:10
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
@gnoff
[Float] support fetchpriority on ReactDOM.preload() and `ReactDOM.p…
ee61e4a 
…reinit()` (#26880)

exposes fetchPriority as an option for `ReactDOM.preload()` and
`ReactDOM.preinit()`

the typings should be `'high' | 'low' | 'auto'`

DiffTrain build for [042d8f6](042d8f6)
@eps1lon eps1lon mentioned this pull request Jun 10, 2023
Closed
@eps1lon
Copy link
Collaborator

eps1lon commented Jun 10, 2023

types: DefinitelyTyped/DefinitelyTyped#65738

@styfle styfle mentioned this pull request Jun 30, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
9e4b87d 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <g@shud.in>
@styfle styfle mentioned this pull request Jul 5, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 6, 2023
@styfle @huozhi
chore(deps): bump react to 7118f5dd7 (#52282)
6dafc42 
Fixes #49409

### React upstream changes

- facebook/react#27045
- facebook/react#27051
- facebook/react#27032
- facebook/react#27031
- facebook/react#27029
- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

---------

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
shuding added a commit to vercel/next.js that referenced this pull request Jul 8, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
1ae3f42 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <g@shud.in>
@eps1lon eps1lon mentioned this pull request Oct 2, 2023
Merged
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
[Float] support fetchpriority on ReactDOM.preload() and `ReactDOM.p…
d8d0a53 
…reinit()` (facebook#26880)

exposes fetchPriority as an option for `ReactDOM.preload()` and
`ReactDOM.preinit()`

the typings should be `'high' | 'low' | 'auto'`
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gnoff
[Float] support fetchpriority on ReactDOM.preload() and `ReactDOM.p…
be35c8a 
…reinit()` (#26880)

exposes fetchPriority as an option for `ReactDOM.preload()` and
`ReactDOM.preinit()`

the typings should be `'high' | 'low' | 'auto'`

DiffTrain build for commit 042d8f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@sophiebits sophiebits Awaiting requested review from sophiebits

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnoff @react-sizebot @eps1lon @sebmarkbage @facebook-github-bot