Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable_concurrentUpdateByDefault option from RTR #28489

Closed

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented Mar 4, 2024

Clean up unused ReactTestRenderer option: unstable_concurrentUpdateByDefault

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 4, 2024
@react-sizebot
Copy link

react-sizebot commented Mar 4, 2024

Comparing: 9ffe910...be25aae

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.83 kB 176.83 kB = 54.91 kB 54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.55 kB 173.55 kB = 54.11 kB 54.11 kB
facebook-www/ReactDOM-prod.classic.js = 594.04 kB 594.04 kB = 104.37 kB 104.37 kB
facebook-www/ReactDOM-prod.modern.js = 577.30 kB 577.30 kB = 101.42 kB 101.42 kB
test_utils/ReactAllWarnings.js Deleted 66.87 kB 0.00 kB Deleted 16.36 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 331.04 kB 330.34 kB = 58.14 kB 58.01 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 315.14 kB 314.43 kB = 55.67 kB 55.55 kB
test_utils/ReactAllWarnings.js Deleted 66.87 kB 0.00 kB Deleted 16.36 kB 0.00 kB

Generated by 🚫 dangerJS against be25aae

@jackpope jackpope force-pushed the rtr-remove-concurrentbydefault branch from 11f5549 to be25aae Compare March 14, 2024 14:39
@jackpope
Copy link
Contributor Author

Closing in favor of #30445

@jackpope jackpope closed this Jul 29, 2024
@jackpope jackpope deleted the rtr-remove-concurrentbydefault branch July 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants