Enable feature flags for v19 #28647
Merged
Enable feature flags for v19 #28647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
commented
Mar 26, 2024
| @@ -180,8 +181,8 @@ export const enableInfiniteRenderLoopDetection = true; | |||
|
|
|||
| // Passes `ref` as a normal prop instead of stripping it from the props object | |||
| // during element creation. | |||
| export const enableRefAsProp = __NEXT_MAJOR__; | |||
| export const disableStringRefs = __NEXT_MAJOR__; | |||
| export const enableRefAsProp = true; | |||
There was a problem hiding this comment.
I'll wait to merge this until I fix that class components ref bug. Or we can flip this to false temporarily and land the rest if I take too long.
There was a problem hiding this comment.
Or we can keep it as __EXPERIMENTAL__ until it's fixed?
acdlite
force-pushed
the
turn-on-19-flags
branch
from
95923cc to
99eef0c
Compare
packages/shared/ReactFeatureFlags.js
Outdated
| @@ -210,7 +221,7 @@ export const enableRenderableContext = __NEXT_MAJOR__; | |||
| // when we plan to enable them. | |||
| // ----------------------------------------------------------------------------- | |||
|
|
|||
| export const disableModulePatternComponents = __NEXT_MAJOR__; | |||
| export const disableModulePatternComponents = true; | |||
There was a problem hiding this comment.
This is under chopping block?
There was a problem hiding this comment.
I have a PR to remove it entirely #27742
rickhanlonii
approved these changes
Mar 26, 2024
|
For the test failure, it looks like we didn't actually remove unmountComponentAtNode yet, you can either wait for this PR or just remove the test gates for now to unblock #28650 |
|
If you rebase on top of main the tests should pass |
acdlite
force-pushed
the
turn-on-19-flags
branch
from
99eef0c to
3c556fe
Compare
The canary channel now represents v19, so we can turn these flags on.
acdlite
force-pushed
the
turn-on-19-flags
branch
from
3c556fe to
891485c
Compare
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
The canary channel now represents v19, so we can turn these flags on.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canary channel now represents v19, so we can turn these flags on.