Remove unmountComponentAtNode outside of legacy mode

[rickhanlonii]

No description provided.

[react-sizebot]

Comparing: 56efb2e...c7a93d8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.93 kB	176.93 kB	=	54.95 kB	54.95 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.33 kB	173.33 kB	=	54.07 kB	54.07 kB
facebook-www/ReactDOM-prod.classic.js	=	595.15 kB	595.15 kB	=	104.52 kB	104.52 kB
facebook-www/ReactDOM-prod.modern.js	=	578.41 kB	578.41 kB	=	101.54 kB	101.54 kB
test_utils/ReactAllWarnings.js	Deleted	65.49 kB	0.00 kB	Deleted	16.16 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	65.49 kB	0.00 kB	Deleted	16.16 kB	0.00 kB

Generated by 🚫 dangerJS against c7a93d8

[kassens]

Is there a way we could gate the whole ReactDOMLegacy.js file to only be included when the flag is off?

[rickhanlonii]

Yeah but IMO there are benefits to just gating each test like greping and being able to split them out later. Like if we start to remove unmountComponentAtNode with a separate flag, it would be nice to not have to refactor this file and just change the gate on those flags.

[rickhanlonii]

I'm... surprised the tests passed with no changes? Yolo