Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set enableUseMemoCacheHook to true everywhere #28964

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

kassens
Copy link
Member

@kassens kassens commented May 1, 2024

Set enableUseMemoCacheHook to true everywhere

Any reason we should have this disabled anywhere? I think we're set on the API?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 1, 2024
@react-sizebot
Copy link

react-sizebot commented May 1, 2024

Comparing: 9b13002...e8fa812

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.29% 492.61 kB 494.06 kB +0.38% 87.88 kB 88.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.92 kB 88.93 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.51% 800.90 kB 804.99 kB +0.56% 174.52 kB 175.50 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.51% 800.93 kB 805.02 kB +0.56% 174.55 kB 175.53 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.50% 812.25 kB 816.34 kB +0.55% 176.13 kB 177.09 kB
oss-stable/react-art/cjs/react-art.development.js +0.50% 812.28 kB 816.37 kB +0.54% 176.15 kB 177.11 kB
oss-stable-semver/react-art/cjs/react-art.production.js +0.50% 289.02 kB 290.47 kB +0.60% 49.86 kB 50.16 kB
oss-stable/react-art/cjs/react-art.production.js +0.50% 289.07 kB 290.52 kB +0.59% 49.89 kB 50.18 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.49% 296.84 kB 298.29 kB +0.57% 52.70 kB 53.00 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.49% 296.89 kB 298.34 kB +0.57% 52.73 kB 53.03 kB
react-native/implementations/ReactFabric-dev.js +0.48% 855.12 kB 859.21 kB +0.55% 185.31 kB 186.33 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.47% 868.30 kB 872.39 kB +0.53% 189.11 kB 190.12 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.45% 915.14 kB 919.22 kB +0.50% 196.71 kB 197.70 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.45% 915.16 kB 919.25 kB +0.50% 196.74 kB 197.73 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js +0.41% 373.58 kB 375.11 kB +0.50% 61.28 kB 61.59 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js +0.41% 373.60 kB 375.14 kB +0.51% 61.30 kB 61.61 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js +0.38% 401.78 kB 403.31 kB +0.45% 65.22 kB 65.51 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js +0.38% 401.80 kB 403.34 kB +0.45% 65.24 kB 65.54 kB
react-native/implementations/ReactFabric-prod.js +0.33% 309.25 kB 310.26 kB +0.48% 54.08 kB 54.34 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js +0.32% 1,281.81 kB 1,285.90 kB +0.34% 284.94 kB 285.90 kB
oss-stable/react-dom/cjs/react-dom-client.development.js +0.32% 1,281.83 kB 1,285.92 kB +0.34% 284.97 kB 285.93 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js +0.31% 1,300.49 kB 1,304.57 kB +0.34% 288.30 kB 289.27 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js +0.31% 1,300.51 kB 1,304.60 kB +0.34% 288.33 kB 289.31 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.31% 318.48 kB 319.47 kB +0.45% 55.70 kB 55.94 kB
react-native/implementations/ReactFabric-profiling.js +0.30% 336.31 kB 337.32 kB +0.44% 58.26 kB 58.52 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js +0.29% 492.54 kB 493.99 kB +0.37% 87.86 kB 88.19 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.29% 492.61 kB 494.06 kB +0.38% 87.88 kB 88.21 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.29% 345.46 kB 346.45 kB +0.40% 59.96 kB 60.19 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js +0.28% 525.41 kB 526.86 kB +0.33% 92.98 kB 93.29 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js +0.28% 525.48 kB 526.93 kB +0.33% 93.01 kB 93.31 kB
oss-stable-semver/react-server/cjs/react-server.production.js +0.23% 105.21 kB 105.46 kB +0.37% 19.29 kB 19.36 kB
oss-stable/react-server/cjs/react-server.production.js +0.23% 105.21 kB 105.46 kB +0.37% 19.29 kB 19.36 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against e8fa812

@kassens kassens requested review from josephsavona and acdlite May 2, 2024 21:56
Any reason we should have this disabled anywhere? I think we're set on the API?
@kassens kassens merged commit b498834 into facebook:main May 6, 2024
38 checks passed
@kassens kassens deleted the pr28964 branch May 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants