Clean up fastAddProperties and make it more correct #29015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 7039834...fbcbb40 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
javache
reviewed
May 7, 2024
Comment on lines
463
to
467
| attributeConfig = validAttributes[propKey]; | ||
|
|
||
| if (attributeConfig === undefined) { | ||
| if (!attributeConfig) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
What I was just mentioning about: we could change the default here and stop ignoring any properties that do not have validAttributes entry.
There was a problem hiding this comment.
That requires the new parser, no? Otherwise, we might get a native exception.
There was a problem hiding this comment.
Update native to ignore unknown props?
This would take us a step closer to removing Static View Configs. We would need this, and a way to specify the bubbling behavior of events. Or we could convert all custom events to be direct, and store a config for which built-in events should bubble (which would also fix the bubbing/direct event name collision bug).
There was a problem hiding this comment.
Update native to ignore unknown props?
This would take us a step closer to removing Static View Configs.
That is already planned!
yungsters
approved these changes
May 7, 2024
| @@ -462,27 +462,27 @@ function fastAddProperties( | |||
|
|
|||
| attributeConfig = validAttributes[propKey]; | |||
|
|
|||
| if (attributeConfig === undefined) { | |||
| if (!attributeConfig) { | |||
There was a problem hiding this comment.
I personally prefer the explicitness of attributeConfig == null (which checks for both undefined and null), but this works, too.
| } else if (typeof attributeConfig.process === 'function') { | ||
| newValue = attributeConfig.process(nextProp); | ||
| } else if (typeof attributeConfig.diff === 'function') { | ||
| newValue = nextProp; |
There was a problem hiding this comment.
Consider leaving an explanatory comment here.
javache
reviewed
May 7, 2024
Comment on lines
469
to
483
| let newValue; | ||
|
|
||
| if (typeof attributeConfig !== 'object') { | ||
| if (!updatePayload) { | ||
| updatePayload = ({}: {[string]: $FlowFixMe}); | ||
| } | ||
| updatePayload[propKey] = nextProp; | ||
| continue; | ||
| if (typeof nextProp === 'function') { | ||
| newValue = (true: any); | ||
| } else if (typeof attributeConfig !== 'object') { | ||
| newValue = nextProp; | ||
| } else if (typeof attributeConfig.process === 'function') { | ||
| newValue = attributeConfig.process(nextProp); | ||
| } else if (typeof attributeConfig.diff === 'function') { | ||
| newValue = nextProp; | ||
| } |
There was a problem hiding this comment.
Could this work?
let newValue = typeof nextProp === 'function' ? true : nextProp;
if (typeof attributeConfig === 'object' && typeof attributeConfig.process === 'function') {
newValue = attributeConfig.process(nextProp);
}
There was a problem hiding this comment.
Could do typeof attributeConfig?.process === 'function', too.
dmytrorykun
force-pushed
the
fix-fastAddProperties
branch
from
81c12a2 to
fbcbb40
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
## Summary This PR makes some fixes to the `fastAddProperties` function: - Use `if (!attributeConfig)` instead of `if (attributeConfig === undefined)` to account for `null`. - If a prop has an Object `attributeConfig` with a `diff` function defined on it, treat it as an atomic value to keep the semantics of `diffProperties`. ## How did you test this change? Build and run RNTester app. DiffTrain build for commit b37e4b4.
eps1lon
added a commit
to vercel/next.js
that referenced
this pull request
May 16, 2024
Completes #65845 which only updated Canary not Experimental. <details> <summary> React upstream changes</summary> - facebook/react#29026 - facebook/react#29025 - facebook/react#28743 - facebook/react#29022 - facebook/react#29023 - facebook/react#29015 - facebook/react#29016 - facebook/react#28988 - facebook/react#28987 - facebook/react#28986 - facebook/react#29014 - facebook/react#28982 - facebook/react#29006 - facebook/react#28973 - facebook/react#28841 - facebook/react#28964 - facebook/react#28990 - facebook/react#29003 - facebook/react#28989 - facebook/react#28893 - facebook/react#28887 - facebook/react#28807 - facebook/react#28978 - facebook/react#28963 - facebook/react#28972 - facebook/react#28970 - facebook/react#28816 - facebook/react#28977 - facebook/react#28974 - facebook/react#28976 - facebook/react#28975 - facebook/react#28969 - facebook/react#28966 - facebook/react#28056 </details>
panteliselef
pushed a commit
to panteliselef/next.js
that referenced
this pull request
May 20, 2024
Completes vercel#65845 which only updated Canary not Experimental. <details> <summary> React upstream changes</summary> - facebook/react#29026 - facebook/react#29025 - facebook/react#28743 - facebook/react#29022 - facebook/react#29023 - facebook/react#29015 - facebook/react#29016 - facebook/react#28988 - facebook/react#28987 - facebook/react#28986 - facebook/react#29014 - facebook/react#28982 - facebook/react#29006 - facebook/react#28973 - facebook/react#28841 - facebook/react#28964 - facebook/react#28990 - facebook/react#29003 - facebook/react#28989 - facebook/react#28893 - facebook/react#28887 - facebook/react#28807 - facebook/react#28978 - facebook/react#28963 - facebook/react#28972 - facebook/react#28970 - facebook/react#28816 - facebook/react#28977 - facebook/react#28974 - facebook/react#28976 - facebook/react#28975 - facebook/react#28969 - facebook/react#28966 - facebook/react#28056 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes some fixes to the
fastAddPropertiesfunction:if (!attributeConfig)instead ofif (attributeConfig === undefined)to account fornull.attributeConfigwith adifffunction defined on it, treat it as an atomic value to keep the semantics ofdiffProperties.How did you test this change?
Build and run RNTester app.