chore[react-devtools]: extract ReactWorkTagMap into a separate module #30567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
vzaidman
approved these changes
Aug 1, 2024
hoxyq
force-pushed
the
react-devtools/extract-work-tag-map-getter
branch
from
67fb2a4
to
e33fb12
Compare
hoxyq
force-pushed
the
react-devtools/extract-work-tag-map-getter
branch
from
e33fb12
to
9005ee2
Compare
|
No longer required. After #30925 the plan is to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #30564 and #30566. See last commit.
We are going to use this
workTagMapin the hook object later. It is used for creating fiber / owner stacks, thats why it will be required by the hook: we are moving all console patches into a single one in a hook.It should be in a separate module to minimize possibility of the hook to depend on something else from the backend, which could increase the script size, see #26563 for more context.