[DevTools] Improve Layering Between Console and Renderer #30925
Merged
+145
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Sep 9, 2024
| typeof registerRendererWithConsole === 'function' && | ||
| typeof patchConsoleUsingWindowValues === 'function' | ||
| ) { | ||
| registerRendererWithConsole(renderer); |
There was a problem hiding this comment.
Since this wasn't injecting an implementation of onErrorOrWarning and is now not injecting a getComponentStack implementation it doesn't actually do anything because we need to inject that actual implementation.
This should get addressed by #30596.
There was a problem hiding this comment.
Agreed. This should be fixed as a part of my stack on moving console patching from Backend to Hook.
…in the renderer We also don't need an error in that implementation affect the component stacks. (Moving try/catch.)
The console patching shouldn't need to know about Fibers.
This doesn't inject onErrorAndWarning and getComponentStack so it doesn't really do anything useful anyway.
sebmarkbage
force-pushed
the
devtoolsrefactorowner
branch
from
a4e34b8
to
863338e
Compare
These internals are not needed. All we need is the onErrorOrWarning and getComponentStack helpers.
sebmarkbage
force-pushed
the
devtoolsrefactorowner
branch
from
863338e
to
c664b9b
Compare
hoxyq
approved these changes
Sep 9, 2024
This was referenced Sep 10, 2024
This was referenced Sep 10, 2024
gnoff
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`** [diff facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d) <details> <summary>React upstream changes</summary> - facebook/react#30952 - facebook/react#30950 - facebook/react#30946 - facebook/react#30934 - facebook/react#30947 - facebook/react#30945 - facebook/react#30938 - facebook/react#30936 - facebook/react#30879 - facebook/react#30888 - facebook/react#30931 - facebook/react#30930 - facebook/react#30832 - facebook/react#30929 - facebook/react#30926 - facebook/react#30925 - facebook/react#30905 - facebook/react#30900 - facebook/react#30910 - facebook/react#30906 - facebook/react#30899 - facebook/react#30919 - facebook/react#30708 - facebook/react#30907 - facebook/react#30897 - facebook/react#30896 - facebook/react#30895 - facebook/react#30887 - facebook/react#30889 - facebook/react#30893 - facebook/react#30892 - facebook/react#30891 - facebook/react#30882 - facebook/react#30881 - facebook/react#30870 - facebook/react#30849 - facebook/react#30878 - facebook/react#30865 - facebook/react#30869 - facebook/react#30875 - facebook/react#30800 - facebook/react#30762 - facebook/react#30831 - facebook/react#30866 - facebook/react#30853 - facebook/react#30850 - facebook/react#30847 - facebook/react#30842 - facebook/react#30837 - facebook/react#30848 - facebook/react#30844 - facebook/react#30839 - facebook/react#30802 - facebook/react#30841 - facebook/react#30827 - facebook/react#30826 - facebook/react#30825 - facebook/react#30824 - facebook/react#30840 - facebook/react#30838 - facebook/react#30836 - facebook/react#30819 - facebook/react#30816 - facebook/react#30814 - facebook/react#30813 - facebook/react#30812 - facebook/react#30811 </details> --------- Co-authored-by: vercel-release-bot <infra+release@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console instrumentation should not know about things like Fibers. Only the renderer bindings should know about that stuff. We can improve the layering by just moving all that stuff behind a
getComponentStackhelper that gets injected by the renderer.This sets us up for the Flight renderer #30906 to have its own implementation of this function.