Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Emit Infinite Promise as a Halted Row #30746

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Stacked on #30731.

When logging a Promise we emit it as an infinite promise instead of blocking the replay on it.

This models that as a halted row instead. No need for this special case.

I unflag the receiving side since now it's used to replace a feature that's already unflagged so it's used.

@sebmarkbage sebmarkbage requested a review from gnoff August 19, 2024 17:27
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 6:54pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 19, 2024
@sebmarkbage
Copy link
Collaborator Author

sebmarkbage commented Aug 19, 2024

One slight nuance is that this will show up as Chunk in DevTools instead of Promise but that's a general issue potentially. #30747

@react-sizebot
Copy link

react-sizebot commented Aug 19, 2024

Comparing: 591adfa...3909a22

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.55% 80.01 kB 80.45 kB +0.15% 15.02 kB 15.05 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.55% 80.01 kB 80.45 kB +0.15% 15.02 kB 15.05 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.55% 80.01 kB 80.45 kB +0.15% 15.02 kB 15.05 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.55% 77.59 kB 78.02 kB +0.45% 16.51 kB 16.58 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.55% 77.59 kB 78.02 kB +0.45% 16.51 kB 16.58 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.55% 77.59 kB 78.02 kB +0.45% 16.51 kB 16.58 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.38% 47.06 kB 47.23 kB +0.35% 9.60 kB 9.63 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.38% 47.06 kB 47.23 kB +0.35% 9.60 kB 9.63 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.38% 47.06 kB 47.23 kB +0.35% 9.60 kB 9.63 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.36% 48.67 kB 48.84 kB +0.32% 9.97 kB 10.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.36% 48.67 kB 48.84 kB +0.32% 9.97 kB 10.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.36% 48.67 kB 48.84 kB +0.32% 9.97 kB 10.00 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.36% 49.00 kB 49.18 kB +0.32% 10.06 kB 10.09 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.36% 49.00 kB 49.18 kB +0.32% 10.06 kB 10.09 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.36% 49.00 kB 49.18 kB +0.32% 10.06 kB 10.09 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.36% 114.55 kB 114.96 kB +0.31% 26.72 kB 26.81 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.36% 114.55 kB 114.96 kB +0.31% 26.72 kB 26.81 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.36% 114.55 kB 114.96 kB +0.31% 26.72 kB 26.81 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.35% 82.02 kB 82.31 kB +0.16% 15.41 kB 15.44 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.35% 82.02 kB 82.31 kB +0.16% 15.41 kB 15.44 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.35% 82.02 kB 82.31 kB +0.16% 15.41 kB 15.44 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js +0.35% 81.73 kB 82.02 kB +0.30% 14.83 kB 14.88 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.35% 81.73 kB 82.02 kB +0.30% 14.83 kB 14.88 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.35% 81.73 kB 82.02 kB +0.30% 14.83 kB 14.88 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.35% 82.47 kB 82.76 kB +0.16% 15.53 kB 15.55 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.35% 82.47 kB 82.76 kB +0.16% 15.53 kB 15.55 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.35% 82.47 kB 82.76 kB +0.16% 15.53 kB 15.55 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.34% 51.31 kB 51.49 kB +0.23% 10.61 kB 10.63 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.34% 51.31 kB 51.49 kB +0.23% 10.61 kB 10.63 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.34% 51.31 kB 51.49 kB +0.23% 10.61 kB 10.63 kB
oss-stable-rc/react-client/cjs/react-client-flight.production.js +0.34% 53.04 kB 53.22 kB +0.31% 9.79 kB 9.82 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js +0.34% 53.04 kB 53.22 kB +0.31% 9.79 kB 9.82 kB
oss-stable/react-client/cjs/react-client-flight.production.js +0.34% 53.04 kB 53.22 kB +0.31% 9.79 kB 9.82 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.34% 85.11 kB 85.40 kB +0.15% 16.27 kB 16.29 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.34% 85.11 kB 85.40 kB +0.15% 16.27 kB 16.29 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.34% 85.11 kB 85.40 kB +0.15% 16.27 kB 16.29 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.34% 52.57 kB 52.75 kB +0.25% 10.89 kB 10.92 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.34% 52.57 kB 52.75 kB +0.25% 10.89 kB 10.92 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.34% 52.57 kB 52.75 kB +0.25% 10.89 kB 10.92 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.33% 86.52 kB 86.81 kB +0.17% 16.58 kB 16.61 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.33% 86.52 kB 86.81 kB +0.17% 16.58 kB 16.61 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.33% 86.52 kB 86.81 kB +0.17% 16.58 kB 16.61 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.33% 53.27 kB 53.44 kB +0.25% 11.04 kB 11.07 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.33% 53.27 kB 53.44 kB +0.25% 11.04 kB 11.07 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.33% 53.27 kB 53.44 kB +0.25% 11.04 kB 11.07 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.33% 87.33 kB 87.62 kB +0.15% 16.74 kB 16.77 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.33% 87.33 kB 87.62 kB +0.15% 16.74 kB 16.77 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.33% 87.33 kB 87.62 kB +0.15% 16.74 kB 16.77 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.33% 54.41 kB 54.59 kB +0.28% 11.27 kB 11.30 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.33% 54.41 kB 54.59 kB +0.28% 11.27 kB 11.30 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.33% 54.41 kB 54.59 kB +0.28% 11.27 kB 11.30 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.33% 54.42 kB 54.60 kB +0.27% 11.26 kB 11.29 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.33% 54.42 kB 54.60 kB +0.27% 11.26 kB 11.29 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.33% 54.42 kB 54.60 kB +0.27% 11.26 kB 11.29 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.32% 88.70 kB 88.99 kB +0.15% 17.03 kB 17.05 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.32% 88.70 kB 88.99 kB +0.15% 17.03 kB 17.05 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.32% 88.70 kB 88.99 kB +0.15% 17.03 kB 17.05 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.32% 88.72 kB 89.00 kB +0.15% 17.01 kB 17.04 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.32% 88.72 kB 89.00 kB +0.15% 17.01 kB 17.04 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.32% 88.72 kB 89.00 kB +0.15% 17.01 kB 17.04 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.31% 90.39 kB 90.67 kB +0.21% 17.07 kB 17.10 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.31% 90.39 kB 90.67 kB +0.21% 17.07 kB 17.10 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.31% 90.39 kB 90.67 kB +0.21% 17.07 kB 17.10 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.31% 91.19 kB 91.47 kB +0.19% 17.24 kB 17.28 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.31% 91.19 kB 91.47 kB +0.19% 17.24 kB 17.28 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.31% 91.19 kB 91.47 kB +0.19% 17.24 kB 17.28 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.30% 56.17 kB 56.33 kB +0.25% 11.39 kB 11.42 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.30% 56.17 kB 56.33 kB +0.25% 11.39 kB 11.42 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.30% 56.17 kB 56.33 kB +0.25% 11.39 kB 11.42 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.30% 56.85 kB 57.02 kB +0.27% 11.56 kB 11.59 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.30% 56.85 kB 57.02 kB +0.27% 11.56 kB 11.59 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.30% 56.85 kB 57.02 kB +0.27% 11.56 kB 11.59 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 131.32 kB 131.66 kB +0.30% 24.42 kB 24.49 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 131.32 kB 131.66 kB +0.30% 24.42 kB 24.49 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.26% 131.32 kB 131.66 kB +0.30% 24.42 kB 24.49 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.26% 131.94 kB 132.28 kB +0.30% 24.61 kB 24.68 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.26% 131.94 kB 132.28 kB +0.30% 24.61 kB 24.68 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.26% 131.94 kB 132.28 kB +0.30% 24.61 kB 24.68 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.25% 132.53 kB 132.86 kB +0.26% 24.64 kB 24.71 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.25% 132.53 kB 132.86 kB +0.26% 24.64 kB 24.71 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.25% 132.53 kB 132.86 kB +0.26% 24.64 kB 24.71 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.25% 132.68 kB 133.01 kB +0.27% 24.71 kB 24.78 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.25% 132.68 kB 133.01 kB +0.27% 24.71 kB 24.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.25% 132.68 kB 133.01 kB +0.27% 24.71 kB 24.78 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.23% 127.57 kB 127.87 kB +0.23% 23.81 kB 23.86 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.23% 127.57 kB 127.87 kB +0.23% 23.81 kB 23.86 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.23% 127.57 kB 127.87 kB +0.23% 23.81 kB 23.86 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.22% 133.94 kB 134.24 kB +0.21% 24.78 kB 24.83 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.22% 133.94 kB 134.24 kB +0.21% 24.78 kB 24.83 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.22% 133.94 kB 134.24 kB +0.21% 24.78 kB 24.83 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.22% 134.10 kB 134.40 kB +0.21% 24.84 kB 24.89 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.22% 134.10 kB 134.40 kB +0.21% 24.84 kB 24.89 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.22% 134.10 kB 134.40 kB +0.21% 24.84 kB 24.89 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.22% 135.05 kB 135.35 kB +0.21% 25.06 kB 25.11 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.22% 135.05 kB 135.35 kB +0.21% 25.06 kB 25.11 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.22% 135.05 kB 135.35 kB +0.21% 25.06 kB 25.11 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.22% 135.20 kB 135.50 kB +0.21% 25.12 kB 25.17 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.22% 135.20 kB 135.50 kB +0.21% 25.12 kB 25.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.22% 135.20 kB 135.50 kB +0.21% 25.12 kB 25.17 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 78.92 kB 78.75 kB = 16.72 kB 16.68 kB

Generated by 🚫 dangerJS against 8e54d43

No need for the special case.
@sebmarkbage sebmarkbage merged commit 52c9c43 into facebook:main Aug 19, 2024
185 checks passed
sebmarkbage added a commit to sebmarkbage/react that referenced this pull request Aug 19, 2024
sebmarkbage added a commit that referenced this pull request Aug 19, 2024
This reverts commit 52c9c43.

Just kidding. We realized we probably don't want to do the halted row
thing after all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants