Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Validate type configs for hooks/non-hooks #30888

Merged
merged 7 commits into from
Sep 10, 2024
Merged

[compiler] Validate type configs for hooks/non-hooks #30888

merged 7 commits into from
Sep 10, 2024

Commits on Sep 5, 2024

  1. [compiler] Validate type configs for hooks/non-hooks 

    [ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    23b6f20 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Validate type configs for hooks/non-hooks" 

    Alternative to #30868. The goal is to ensure that the types coming out of moduleTypeProvider are valid wrt to hook typing. If something is named like a hook, then it must be typed as a hook (or don't type it).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6e4115a View commit details
    Browse the repository at this point in the history

  3. Update on "[compiler] Validate type configs for hooks/non-hooks" 

    Alternative to #30868. The goal is to ensure that the types coming out of moduleTypeProvider are valid wrt to hook typing. If something is named like a hook, then it must be typed as a hook (or don't type it).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7a6efb2 View commit details
    Browse the repository at this point in the history

  4. Update on "[compiler] Validate type configs for hooks/non-hooks" 

    Alternative to #30868. The goal is to ensure that the types coming out of moduleTypeProvider are valid wrt to hook typing. If something is named like a hook, then it must be typed as a hook (or don't type it).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0a8bea2 View commit details
    Browse the repository at this point in the history

  5. Update on "[compiler] Validate type configs for hooks/non-hooks" 

    Alternative to #30868. The goal is to ensure that the types coming out of moduleTypeProvider are valid wrt to hook typing. If something is named like a hook, then it must be typed as a hook (or don't type it).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c37ac41 View commit details
    Browse the repository at this point in the history

  6. Update on "[compiler] Validate type configs for hooks/non-hooks" 

    Alternative to #30868. The goal is to ensure that the types coming out of moduleTypeProvider are valid wrt to hook typing. If something is named like a hook, then it must be typed as a hook (or don't type it).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c26ca80 View commit details
    Browse the repository at this point in the history

  7. Update on "[compiler] Validate type configs for hooks/non-hooks" 

    Alternative to #30868. The goal is to ensure that the types coming out of moduleTypeProvider are valid wrt to hook typing. If something is named like a hook, then it must be typed as a hook (or don't type it).

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9df57a0 View commit details
    Browse the repository at this point in the history