Update 04-multiple-components.md #7139
Conversation
Just had a discussion about this on reactiflux, and the use of "component" here to mean potentially both ReactElement and ReactComponent has already caused some confusion about assigning keys to ReactElements within loops. If the word component is officially a catch-all term, the glossary should provide more guidance about this.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
added
the
| @@ -124,7 +124,7 @@ The situation gets more complicated when the children are shuffled around (as in | |||
|
|
|||
| When React reconciles the keyed children, it will ensure that any child with `key` will be reordered (instead of clobbered) or destroyed (instead of reused). | |||
|
|
|||
| The `key` should *always* be supplied directly to the components in the array, not to the container HTML child of each component in the array: | |||
| The `key` should *always* be supplied directly to the elements or components in the array, not to the container HTML child of each component in the array: | |||
There was a problem hiding this comment.
HTML child
That's also pretty wrong and confusingly worded. Want to try to clean the rest of this up as well?
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks for the PR! We just released new docs mostly written from scratch. However this means that all old localized content is gone, as new one needs to be written. We will track this effort in #8063. The goal is to make it easier for people to review localizations so you wouldn't have to wait for the core team, and your PRs would be reviewed much faster. Sorry, and thank you for your work! |
Just had a discussion about this on reactiflux, and the use of "component" here to mean potentially both ReactElement and ReactComponent has already caused some confusion about assigning keys to ReactElements within loops. If the word component is intended to be a catch-all term, the glossary should provide explicit guidance on this.