Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"transient dependencies" -> "transitive dependencies" #7341

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

amasad
Copy link
Contributor

@amasad amasad commented Jul 23, 2016

I think that's what you meant -- although with npm dependencies are kind of transient :P

I think that's what you meant -- although with npm dependencies are kind of transient :P
@ghost
Copy link

ghost commented Jul 23, 2016

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@amasad
Copy link
Contributor Author

amasad commented Jul 23, 2016

CLA form seems to be down.

@gaearon
Copy link
Collaborator

gaearon commented Jul 23, 2016

Oh thanks :P
Can you send a PR against the repo as well?

@amasad
Copy link
Contributor Author

amasad commented Jul 25, 2016

@zpao
Copy link
Member

zpao commented Jul 25, 2016

(y) thanks!

@zpao zpao merged commit d157827 into facebook:master Jul 25, 2016
zpao pushed a commit that referenced this pull request Jul 28, 2016
I think that's what you meant -- although with npm dependencies are kind of transient :P
(cherry picked from commit d157827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants